Date: Wed, 23 Jan 2019 00:19:44 +0100 From: Guido Falsi <madpilot@FreeBSD.org> To: =?UTF-8?Q?T=c4=b3l_Coosemans?= <tijl@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r490973 - head/deskutils/xfce4-volumed Message-ID: <de274485-03a4-2c7d-db9f-d0e4ef7cf119@FreeBSD.org> In-Reply-To: <20190122203337.120c1bad@kalimero.tijl.coosemans.org> References: <201901221850.x0MIojFp085050@repo.freebsd.org> <20190122203337.120c1bad@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22/01/19 20:33, Tijl Coosemans wrote: > On Tue, 22 Jan 2019 18:50:45 +0000 (UTC) Guido Falsi <madpilot@FreeBSD.org> wrote: >> Author: madpilot >> Date: Tue Jan 22 18:50:45 2019 >> New Revision: 490973 >> URL: https://svnweb.freebsd.org/changeset/ports/490973 >> >> Log: >> - Add missing dependencies >> - Sort lists >> - Fix portlint warnings >> >> PR: 235128 >> Submitted by: myself >> Approved by: Sergey V. Dyatko <sergey.dyatko@gmail.com> (Maintainer) >> >> Modified: >> head/deskutils/xfce4-volumed/Makefile >> >> Modified: head/deskutils/xfce4-volumed/Makefile >> ============================================================================== >> --- head/deskutils/xfce4-volumed/Makefile Tue Jan 22 18:48:38 2019 (r490972) >> +++ head/deskutils/xfce4-volumed/Makefile Tue Jan 22 18:50:45 2019 (r490973) >> @@ -3,7 +3,7 @@ >> >> PORTNAME= xfce4-volumed >> PORTVERSION= 0.1.13 >> -PORTREVISION= 2 >> +PORTREVISION= 3 >> CATEGORIES= deskutils xfce >> MASTER_SITES= XFCE/src/apps/${PORTNAME}/${PORTVERSION:R} >> DIST_SUBDIR= xfce4 >> @@ -13,13 +13,18 @@ COMMENT= Volume management daemon for the Xfce desktop >> >> LICENSE= GPLv3 >> >> -LIB_DEPENDS= libnotify.so:devel/libnotify \ >> - libkeybinder.so:x11/keybinder >> +LIB_DEPENDS= libdbus-glib-1.so:devel/dbus-glib \ >> + libdbus-1.so:devel/dbus \ >> + libnotify.so:devel/libnotify \ >> + libkeybinder.so:x11/keybinder \ >> + libfontconfig.so:x11-fonts/fontconfig \ >> + libfreetype.so:print/freetype2 >> >> -USES= pkgconfig gmake xfce tar:bzip2 >> -GNU_CONFIGURE= yes >> -USE_GNOME= glib20 >> +USES= gmake gnome pkgconfig tar:bzip2 xfce >> +USE_GNOME= atk cairo gdkpixbuf2 glib20 gtk20 libxml2 pango > > These dependencies need to be added to Mk/Uses/gnome.mk instead of every > single gtk port. They are caused by > /usr/local/libdata/pkgconfig/gtk+-x11-2.0.pc and > /usr/local/libdata/pkgconfig/pangoft2.pc. > You definitely have a point here, but I was working only on the xfce ports. Most xfce ports already had these registered. I thought it was correct to align them all. -- Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?de274485-03a4-2c7d-db9f-d0e4ef7cf119>