From owner-svn-ports-all@FreeBSD.ORG Mon Dec 2 10:08:14 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E3F59F6D; Mon, 2 Dec 2013 10:08:14 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A3249151B; Mon, 2 Dec 2013 10:08:14 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 30028BDC3E; Mon, 2 Dec 2013 11:08:10 +0100 (CET) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) by prod2.absolight.net (Postfix) with ESMTPA id 1D483BDC2E; Mon, 2 Dec 2013 11:08:10 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by atuin.in.mat.cc (Postfix) with ESMTP id A39C0C903BDB; Mon, 2 Dec 2013 11:08:09 +0100 (CET) Date: Mon, 02 Dec 2013 11:08:08 +0100 From: Mathieu Arnold To: Gerald Pfeifer , Mathieu Arnold , Kozlov Sergey , Greg Larkin Subject: Re: svn commit: r335189 - in head/print/pdftk: . files Message-ID: In-Reply-To: References: <201311291548.rATFm8g7098382@svn.freebsd.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 10:08:15 -0000 +--On 1 d=C3=A9cembre 2013 23:21:51 +0100 Gerald Pfeifer = wrote: | On Fri, 29 Nov 2013, Mathieu Arnold wrote: |> Log: |> Updated port to pdftk-2.02 | : |> - Added LIB_DEPENDS. Libraries provided by gcc required to run the |> binary, but gcc is registered only as build dependency. Removing the |> gcc after installation of pdftk is permitted but breaks pdftk |=20 | This looks quite dubious since USE_GCC already takes care of=20 | registering this run-time dependency. |=20 | USE_GCC also takes care of the BUILD_DEPENDency, so the pre-existing | entry there also is unnecessary. Hum, does GCC always come with gcj ? I thought it did not, that's why there was an explicit dependency on it. |> maintainer timeout. |=20 | This reminds me, I had submitted another patch in August 2012 (per | mail, not PR). The -Wl,-path magic is not necessary and manually | constructing the path to the GCC run-time libraries is A Bad Idea[TM]. | This is what ${LDFLAGS} is there for, and what the second, and more | important hunk, in my patch below does. |=20 | Can you guys please give the patch below a spin and review? The patch looks ok to me, but I don't know a lot about how all that dark magic works :-p --=20 Mathieu Arnold