From owner-freebsd-acpi@FreeBSD.ORG  Wed Mar 25 23:20:05 2009
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0FDA6106564A
	for <freebsd-acpi@hub.freebsd.org>;
	Wed, 25 Mar 2009 23:20:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id F19908FC25
	for <freebsd-acpi@hub.freebsd.org>;
	Wed, 25 Mar 2009 23:20:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n2PNK4W3033069
	for <freebsd-acpi@freefall.freebsd.org>; Wed, 25 Mar 2009 23:20:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n2PNK4nj033068;
	Wed, 25 Mar 2009 23:20:04 GMT (envelope-from gnats)
Date: Wed, 25 Mar 2009 23:20:04 GMT
Message-Id: <200903252320.n2PNK4nj033068@freefall.freebsd.org>
To: freebsd-acpi@FreeBSD.org
From: Bruce Cran <bruce@cran.org.uk>
Cc: 
Subject: Re: kern/108581: [sysctl] sysctl: hw.acpi.cpu.cx_lowest: Invalid
 argument
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Bruce Cran <bruce@cran.org.uk>
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Mar 2009 23:20:05 -0000

The following reply was made to PR kern/108581; it has been noted by GNATS.

From: Bruce Cran <bruce@cran.org.uk>
To: bug-followup@FreeBSD.org, lars.stokholm@gmail.com
Cc:  
Subject: Re: kern/108581: [sysctl] sysctl: hw.acpi.cpu.cx_lowest: Invalid
 argument
Date: Wed, 25 Mar 2009 23:13:55 +0000

 --MP_/.Mqqm3g9tTbq0b=KU9SrVSj
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 
 --MP_/.Mqqm3g9tTbq0b=KU9SrVSj
 Content-Type: text/plain
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=acpi_cpu.c.diff.txt
 
 --- acpi_cpu.c	2009-03-25 23:06:24.000000000 +0000
 +++ sys/dev/acpica/acpi_cpu.c	2009-03-25 23:07:45.000000000 +0000
 @@ -742,7 +742,7 @@
       */
      acpi_cpu_quirks();
  
 -    cpu_cx_count = 0;
 +    cpu_cx_count = 3;
      if (cpu_cx_generic) {
  	/*
  	 * We are using generic Cx mode, probe for available Cx states
 @@ -775,7 +775,7 @@
  	    if (cpu_quirks & CPU_QUIRK_NO_C3) {
  		sc->cpu_cx_count = sc->cpu_non_c3 + 1;
  	    }
 -	    if (sc->cpu_cx_count > cpu_cx_count)
 +	    if (sc->cpu_cx_count < cpu_cx_count)
  		cpu_cx_count = sc->cpu_cx_count;
  	    AcpiInstallNotifyHandler(sc->cpu_handle, ACPI_DEVICE_NOTIFY,
  		acpi_cpu_notify, sc);
 
 --MP_/.Mqqm3g9tTbq0b=KU9SrVSj--