From owner-svn-src-head@freebsd.org Fri Apr 5 15:05:58 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E70CB1579AD2 for ; Fri, 5 Apr 2019 15:05:57 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F053F95720 for ; Fri, 5 Apr 2019 15:05:56 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1554476749; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=X/P5ujv19IN6V+3IO7j+DyNtor9GkdowcX3i4hKkvt95cy+1NNoKMznqmzNgqH7T4Va55YhBGv90H 0HRWsIYXmST9wlWdDKZJCXewhHo6NX75/Tv6dt87ZpYfEW2/eJDjpgQ56jfSAv8OTub1eo3VTGv2Ox v1XnCSh9t3NxciWpIPbAgOIZ6DfkVSfvOYRMbUAWKRejvT0YR+v48Ze8MpXdu1VyaUUB7CVg13u5fA z8VSvM9y4MFSA5jP8B0Axx5RekbH/p/iqObCajDdXUJnZY38rVIJgL3rEAA7812QruldU5BAbwCDDp 6T0YF+U0s8co4j1aDcyS/i1YvxHRJhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=wlWSTboTNNw0270DEzzCehl21KqHGPZecSax5wlCHjk=; b=hPGlzbHHIGz24emp3i11dnIuBjqUEBhxFrygUbDqVr+ZVfYhVECxNIoXiKSJ5X+l+Ywlgq35HxPZo K7doqh+ox0dLu9xKkFNltaIwu1P1+vCzba1u7AChkUpxoDCXT6TS5B1goNUCOMq15RJYJsB2/PImLn Z+cULlVnQ3cw+UAQEKnjo5TUdlRWZ9sYH2a0N0BjpqIhnRAQnqwFbir/vvm1c3ugblevP94yfP7U9Y WiSYe5tPOyCvIDR1tV0g3Q9hnHoJK2ITP9bAdVjxMypD/fHwK+WlZeDBW0s2i/j+xftAB5VEMXj3Q5 BL/E62Mt/JMSDt240dJjlXVh0MsDqRA== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=wlWSTboTNNw0270DEzzCehl21KqHGPZecSax5wlCHjk=; b=F0tHa26ylAMv65xuzi8dFKYmCEtZENgAgk2xkORn4b06x/36wSoUT0UwVIr/19nnVxFgih2JZpJKW sPz6Kf872my5HzZZzOM4lm6roQSItFXhyD3yxdWOkl5ZzSrTouQZNnP7L4bGuVGG9T16CaOiUATdMv pygNQz/hpnNGcBfyzfhtaibdwlA3NydxUh3+Hzatr0VHk0rHlSpGcPZaSWldjk/wMhfaoYKFjzZoOw ciVOSd5w7+RkNRVetNRNAqz+3XwC/0l4VpVWLxbuIJUvAHc+lv94QAKlJfQgzrUxQ5zgNINoeedDxI PEsuRrmxnUF+TEKLzdqrAIdTV+AOJGA== X-MHO-RoutePath: aGlwcGll X-MHO-User: 4b3b0157-57b4-11e9-befd-af03bedce89f X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 4b3b0157-57b4-11e9-befd-af03bedce89f; Fri, 05 Apr 2019 15:05:48 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x35F5lBc005249; Fri, 5 Apr 2019 09:05:47 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <75f6609a7c532df05a4a18442f4e14708b788f28.camel@freebsd.org> Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs From: Ian Lepore To: Bruce Evans , Ed Maste Cc: "Rodney W. Grimes" , Xin LI , src-committers , svn-src-all , svn-src-head Date: Fri, 05 Apr 2019 09:05:47 -0600 In-Reply-To: <20190406014249.N4174@besplex.bde.org> References: <201904050221.x352LGjU015040@repo.freebsd.org> <201904050449.x354nUEC036896@gndrsh.dnsmgr.net> <20190406014249.N4174@besplex.bde.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F053F95720 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.992,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2019 15:05:58 -0000 On Sat, 2019-04-06 at 01:47 +1100, Bruce Evans wrote: > On Fri, 5 Apr 2019, Ed Maste wrote: > > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: > >> > > > >>> +static const u_char dot_name[] = { > >>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > >>> +static const u_char dotdot_name[] = { > >>> + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > >>> + > >> > >> Does it make since to encode these as hex or octal constants, > >> one can not tell that those are different values in an easy > >> manner. They all look like '.' in the diff, and probably > >> in most editors. > > No, but it makes sense to write them as string constants. They are just > the strings "." and ".." padded with spaces to length 11, except they > are not actually strings since they are not NUL terminated. 11 is for > 8+3 msdos short file names. These are not NUL terminated either, but > it should be easy to ignore the extra NUL given by the string constants. > Defining them as nulterminated strings will also affect sizeof(dot_name), better make sure nothing relies on that. -- Ian