From nobody Mon Jan 2 20:48:20 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nm7Hs08nMz2lK4L for ; Mon, 2 Jan 2023 20:48:41 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic305-21.consmr.mail.gq1.yahoo.com (sonic305-21.consmr.mail.gq1.yahoo.com [98.137.64.84]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nm7Hq6wWzz3yv3 for ; Mon, 2 Jan 2023 20:48:39 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=PwwwBbzx; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.64.84 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672692518; bh=7htH60uzccMfmgBpSCbysFvozh61ZzGlimGyCy2XGiY=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=PwwwBbzxcdnYZbN5QcQQ+MjUDxUGI9HIu8uAUCmrAsQ+MWD7VmWq9MqG/1TCwrALq8bmqTsFr2kd1vI1OW4B+jTezDxJjvPvBXxNABVabrsRZCD08ITo82WexAcE7R0FEPFCn0NdvOzwGfrXW54mUAtMyCVPhMOEMmQDCjITfy79PrLhGXHEHFP1f5usHRx1m2BJeSq17LgtsU6Mwsnu/XbsfDFOrwH9cq6fxd/rar6wgJE6tYZRi2bMmsgerNmG0ZtCgQSppVvhIRJBWEvWHmhjjljllgJTkiE2NCtaEPQ9PklPBi7nTUPNaxbwV6xYBhCQelUU6mNaogLrAm9eNA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672692518; bh=jA+H9zpH5E62XmYogAaH+Q9xzBKkY0v4IVyyqVQZSfg=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=buw8kRuaq6hZSRvI9SfqUhthLbr8tCwN51vS6/FXiVDC+62jxUIxK+xlILydBzWLXQxzEoBLsGNftBQGbZgyux212hKVk99pGsVhNOA829eKr8K0ymJjK+DWw1Fhsk0DI/rK9ElhPpry+pRhdgZdxE4TkhunauzitKTKjgxMo0m1LLCWRf1MOOwzDDqxJf8DPV1WLLHXbMoW78+GtM+AU50i20+/DaG1eSHKpSXk7Up4n6FFZ6UGiPZiFiDrk8DnGQrCrIJKqs0qf4o9twhQwECQmO4e80HodQZIUnNQkpU8pqP2RT9Oie6Ns5vtfr2Jt17SYRNtnOlx5+Z18NVV4g== X-YMail-OSG: Yhrfw9MVM1mbjqHZZuuyfR8..Fiaz7Uo23Be0CW.2YI4YfNH91tguRSCCAUFfnA SlThWDDF3divpn5lLk57lsOGkSgnnvfCzrJt29lmlooE5GuOvVWpWKbTprN7tOrF.fK1VIdXNcE_ jhZThXTn7cYkFgsX97Tfi6QduF2rlwQCJocZf0z9mfv6RH_usANGAijgXt_ZIkhposh2anRE1Zp8 j34vVo2Tg_dZxj6HrB582WJLkmB54u.1KH7NTn4B7fKPsr05ocPXpUBR1otbIsMasvyGUnbWdXH0 HU_59_6_bQi5.nTC0dsVoZhsQNL2pTG_GEhL5mc2pwe5st661VNfCklYlxOop7IaqsJQH6SQmc_G I8JDYXZ5j5_2Y0rlUBUL5uxXDOh2NP9Oe4O6utOVkNXxj_deOAsvwsT7VLi6KQF_RKh1m1BKlXiJ cHipoHI8AdBVpHp72EHk8TdYl9QX2vSZVCUz.RCpEOo.Id.yrRpy_XAcGcTFgY4iu3S_p9oHaQ18 qifwb79at.Z1ikfTO3jhcyFu648xw3NSJyhj7eAN4AYt4N99eI6n22Iqn9MP3y4zF0xiXynIl_.r VMk.mjUAPHpHcTTQZy8FiE1jLUsNNLBICmFzOG16nLb_xoHTr8RqA.t1CR.9PBXwZL1JEgjCN0.1 cKd07ziNKJPwhgNAi3BYZKaT2JApvJiAvDCpXddZxxox4C00R0yAcvo5kI3fi4gD3uLWq2O2CLwr HwSR9Or2FGJ82jyhrcd.6XRkdldbCcOQOaipV97Xz9FwwJN0.ijBUXbivikwbdQ_iruUKgYMFJUd 9AS0MphnbnKOP3rCVSN01_rLS1a9g.VryVgIIcNIggQxkaP3Flnr9LLYzgil.zuhxs5FkT8vk7LK D0XOCOJX3lhVvzR8xRuQJlUW42XKKzWoTZQmQM3G.sn7kTlTzi.LZ.3Z1oKBdMCIxefmTa70MdmG l5828ewfutjvbyH4ONy2tk2fhF3s7O_cRz7SBjeNnhrQXEStvmlSNcewLYtziWY1nlCoBborBUtc l.3OKnT3Twwil.XCaqc8tQ31ILayFFqsEoT4AMoJSYCgXqQ1iwqfFx2OxPbuDwAwW37JQM0_bL2f qpjJO7seL5h5ECAcoXP4HXlbo_gmn3t14oBM86eWjbVmayXA.vbISGsFRjoUXFi1OediKMPdnajG QU9Bp8ZjagPFFLeSPNnB45m_aPxojNaLwCvKY2.rA2HteAhNzXHDd2_P8qxkhb1qmp0HobImJIs1 Z8PVPv2gZI7qSbKeXL0D4oT3qUn0KSePFjuBNAAp8dsXRNMPLPu0DnCynC_tt5AJd23L6TyZukec 6iD84ntnORLKch0L_43MRgueFHOYYAwFhZorIs.tJCK_6Me_ZeG7tkZN7aLjIGbKo_O5hFKfDfEu wgHc17d_tUFYGOLUcaFTglDd8E6tZBOSOY6LI0.3fqLcw2RixggeK9xrc1CRcXS58s9FgVVgGyDb NJs2TFGc1w4bFiExZJvsedGgYeuYtFBQQMdq2KU7kjDHAJHDTgSj4PC7Oc1KC79HVW6q6s0BtnUS 3ff1JQXNraFBLtkwexJOL5z5Rx8fvqqjyl3CQwgB9VR2sI3bnpzkTJCfg_M7aGiH5ZFfWSAhHYDM ja7aSyYHOxGGYHRclWUKTkiUlnj3h3ONbt2SunCU0AIh4knNEr7OdkNfHAQYTVEjxvBnXFnCKy4N mU.7efaRdboB41pkho2gnjeO_QRbXDvssl.bIt3_3Hhp1Gq2nJwx5QgxnIZp3WWuSBXxRHjb3se9 cKXRDpEel.E8ubDMz85qjXoSPvgjGwQGYHduEApo94YXCUPyQvy8.US4Ibwa4vosHs8SInSneJCu LJ2MaWrupIFpBarHRi6OGaiWeHzlPn0sWoNalIvqdg4Q5UMyrBC0RHEf87v9lW3QNvspdR.xaGaJ FMZIZpi29ybjLNY.afOGrCyOiPCc2532BfrLU1hngFkI80MHoIoN51MNG.KNxfmC.nZpy.Ex61Op 1xGsXzmUC_HcZHNmSf4RHRrLxvqgKC.WAp8DKhx8n2g62Sl1t87lk3l5NKHcSgaiERcAtwWUIo9y xkA.IoZwTKbUH7KEcV0bDDqTEYXszDZ7Qiafu_z74xKoI9CpNhyQfUhrT7PP3PuVenX5fl9s5uoD QFo8ZjQZpQxYWnF7V8tTz7CT5gXz124TW5tJNRJD2SnFgU6_kJqh0QsCv1kA3_sGznxp_V0FNq6k 8gruDqPLUCyP3qfUonCNdijJKH.ozSIFL_dUO7hRKYVtR9qSoh4FfTXaONl4zjrT1AWmVn_hjjUT . X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.gq1.yahoo.com with HTTP; Mon, 2 Jan 2023 20:48:38 +0000 Received: by hermes--production-ne1-7b69748c4d-xhmc5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a842febea0e606727be7d724c2d1212c; Mon, 02 Jan 2023 20:48:33 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: git: d670a8f7c596 - main - growfs_fstab: add new /etc/rc.d script to add swap to fstab From: Mark Millard In-Reply-To: <36A98BE4-83C7-4E23-A4B1-A761D5F22DD4@karels.net> Date: Mon, 2 Jan 2023 12:48:20 -0800 Cc: "karels@freebsd.org" , dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <3445E24D-FA0B-4124-9900-0EEA66BCF7E6@yahoo.com> References: <3F68EC4A-1D8A-409B-81D0-BECE377EFBE7.ref@yahoo.com> <3F68EC4A-1D8A-409B-81D0-BECE377EFBE7@yahoo.com> <36A98BE4-83C7-4E23-A4B1-A761D5F22DD4@karels.net> To: Mike Karels X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spamd-Result: default: False [-3.29 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.79)[-0.794]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RCVD_IN_DNSWL_NONE(0.00)[98.137.64.84:from]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org] X-Rspamd-Queue-Id: 4Nm7Hq6wWzz3yv3 X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N On Dec 26, 2022, at 06:57, Mike Karels wrote: >=20 > On 25 Dec 2022, at 16:41, Mark Millard wrote: >=20 >> Mike Karels wrote on >> Date: Sat, 10 Dec 2022 19:41:14 UTC : >>=20 >>> The branch main has been updated by karels: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dd670a8f7c596fd387823644c5cbf1dde= e788eee4 >>>=20 >>> commit d670a8f7c596fd387823644c5cbf1ddee788eee4 >>> Author: Mike Karels >>> AuthorDate: 2022-12-10 19:39:59 +0000 >>> Commit: Mike Karels >>> CommitDate: 2022-12-10 19:39:59 +0000 >>>=20 >>> growfs_fstab: add new /etc/rc.d script to add swap to fstab >>>=20 >>> The growfs_fstab script is a helper for the growfs script to add any >>> new swap partition to /etc/fstab on first boot. If growfs adds a >>> swap partition, it sets growfs_swap_pdev in the kenv. In this case, >>> after the root file system is read/write, if there is no swap = partition >>> in the fstab, growfs_fstab adds growfs_swap as a swap partition to = the >>> fstab. Also, it runs dumpon to add the swap partition (as this >>> happened earlier in the startup sequence). >>>=20 >>> Discussed with: cperciva >>> Differential Revision: https://reviews.freebsd.org/D37463 >>> . . . >>=20 >> I tried the new main [so: 14] snapshot, dd'd to a USB3 SSD and = booted: >>=20 >> snaphot: = FreeBSD-14.0-CURRENT-arm64-aarch64-RPI-20221224-c89209c674f2-259842.img >> so: FreeBSD 14.0-CURRENT #0 main-n259842-c89209c674f2: Sat Dec 24 = 05:52:28 UTC 2022 >>=20 >> Result (from the serial console capture): >>=20 >> Starting file system checks: >> /dev/ufs/rootfs: FILE SYSTEM CLEAN; SKIPPING CHECKS >> /dev/ufs/rootfs: clean, 599506 free (242 frags, 74908 blocks, 0.0% = fragmentation) >> /etc/rc.d/growfs: 203: Syntax error: "(" unexpected (expecting "}") >>=20 >>=20 >> Looks to be the ' in "Don't" in a supposed #comment that that instead = matches a prior awk use of ' unintentionally. Later in the line is: = "(decimal)" that supplies the "(" reported. >=20 > I ran into this over the weekend too. Fixed by 4c8a257810a6. >=20 For the new snapshot of main FreeBSD 14.0-CURRENT #0 main-n259905-231d75568f16: Sun Jan 1 11:28:27 = UTC 2023 = root@releng1.nyi.freebsd.org:/usr/obj/usr/src/arm64.aarch64/sys/GENERIC I ended up with: # gpart show=20 =3D> 63 62333889 mmcsd0 MBR (30G) 63 1985 - free - (993K) 2048 102400 1 fat32lba [active] (50M) 104448 62228480 2 freebsd (30G) 62332928 1024 - free - (512K) =3D> 0 62228480 mmcsd0s2 BSD (30G) 0 128 - free - (64K) 128 62228352 1 freebsd-ufs (30G) So no swap. Looks like it got "gpart: Invalid start param: Invalid = argument" . . . Starting file system checks: /dev/ufs/rootfs: FILE SYSTEM CLEAN; SKIPPING CHECKS /dev/ufs/rootfs: clean, 599451 free (483 frags, 74871 blocks, 0.0% = fragmentation) Growing root partition to fill device random: randomdev_wait_until_seeded unblock wait random: unblocking device. Adding swap partition GEOM_PART: mmcsd0s2 was automatically resized. Use `gpart commit mmcsd0s2` to save changes or `gpart undo mmcsd0s2` = to revert them. mmcsd0s2 resized gpart: Invalid start param: Invalid argument mmcsd0s2a resized super-block backups (for fsck_ffs -b #) at: 11524224, 12804672, 14085120, 15365568, 16646016, 17926464, 19206912, 20487360, 21767808, 23048256, 24328704, 25609152, 26889600, 28170048, 29450496, 30730944, 32011392, 33291840, 34572288, 35852736, 37133184, 38413632, 39694080, 40974528, 42254976, 43535424, 44815872, 46096320, 47376768, 48657216, 49937664, 51218112, 52498560, 53779008, 55059456, 56339904, 57620352, 58900800, 60181248, 61461696 Swap partition not found on mmcsd0s2 dumpon: /dev/label/growfs_swap: No such file or directory =3D=3D=3D Mark Millard marklmi at yahoo.com