From owner-p4-projects  Fri May 31  6:48:18 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 44C5937B400; Fri, 31 May 2002 06:48:06 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 4E64637B40D
	for <perforce@freebsd.org>; Fri, 31 May 2002 06:48:00 -0700 (PDT)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g4VDm0e19531
	for perforce@freebsd.org; Fri, 31 May 2002 06:48:00 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Fri, 31 May 2002 06:48:00 -0700 (PDT)
Message-Id: <200205311348.g4VDm0e19531@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 12197 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=12197

Change 12197 by rwatson@rwatson_curry on 2002/05/31 06:47:16

	Missing unlock of Giant if internalize fails (which it doesn't)

Affected files ...

... //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#149 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#149 (text+ko) ====

@@ -2171,6 +2171,7 @@
 	error = mac_internalize(&intlabel, &extmac);
 	if (error) {
 		crfree(newcred);
+		mtx_unlock(&Giant);
 		return (error);
 	}
 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message