Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Jan 1997 15:33:40 +0800
From:      Peter Wemm <peter@spinner.DIALix.COM>
To:        Brian Somers <brian@freefall.freebsd.org>
Cc:        CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-share@freefall.freebsd.org
Subject:   Re: cvs commit: src/share/doc/handbook contrib.sgml 
Message-ID:  <199701180733.PAA03742@spinner.DIALix.COM>
In-Reply-To: Your message of "Fri, 17 Jan 1997 20:46:15 PST." <199701180446.UAA20874@freefall.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
Brian Somers wrote:
> brian       97/01/17 20:46:14
> 
>   Modified:    share/doc/handbook  contrib.sgml
>   Log:
>   Oh look - it's alphabetical too....... if at first you don't succeed...
>   Reviewed by:	None
>   Submitted by:   Brian Somers <brian@awfulhak.demon.co.uk>
>   Obtained from:  Brian Somers <brian@awfulhak.demon.co.uk>

BTW, the "reviewed by" tags etc are unnecessary in cases like this..

In general, if somebody submits something, the person who commits it is
assumed to have reviewed it (at least casually) unless they state otherwise
in the commit message.  ie: it's not really appropriate for the committer
to list himself as the reviewer (unless it's a major review worthy of note
I guess). 

"Submitted by" and "Obtained from" are generally mutually exclusive.  
"Submitted by" means somebody sent something explicitly for inclusion, 
while "obtained from" means that the change was _taken_ from somewhere 
else.. eg: from a non-freebsd related mailing list, another OS project 
etc.

Cheers,
-Peter





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199701180733.PAA03742>