From owner-svn-src-all@freebsd.org  Tue Oct 22 15:26:50 2019
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7331815D872;
 Tue, 22 Oct 2019 15:26:50 +0000 (UTC)
 (envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (glebi.us [162.251.186.162])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 46yHRY5Fwjz3Q7j;
 Tue, 22 Oct 2019 15:26:49 +0000 (UTC)
 (envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id x9MFQkLX086227
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 22 Oct 2019 08:26:46 -0700 (PDT)
 (envelope-from glebius@freebsd.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id x9MFQkqA086226;
 Tue, 22 Oct 2019 08:26:46 -0700 (PDT)
 (envelope-from glebius@freebsd.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@freebsd.org using -f
Date: Tue, 22 Oct 2019 08:26:46 -0700
From: Gleb Smirnoff <glebius@freebsd.org>
To: Enji Cooper <yaneurabeya@gmail.com>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r353732 - head/sys/net
Message-ID: <20191022152646.GI4086@FreeBSD.org>
References: <201910181520.x9IFKOd2094171@repo.freebsd.org>
 <21F302BD-CF03-4129-B5DD-7DC3BE481152@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <21F302BD-CF03-4129-B5DD-7DC3BE481152@gmail.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
X-Rspamd-Queue-Id: 46yHRY5Fwjz3Q7j
X-Spamd-Bar: -
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-1.54 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-0.54)[-0.544,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0];
 ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 15:26:50 -0000

On Tue, Oct 22, 2019 at 07:53:31AM -0700, Enji Cooper wrote:
E> > Author: glebius
E> > Date: Fri Oct 18 15:20:24 2019
E> > New Revision: 353732
E> > URL: https://svnweb.freebsd.org/changeset/base/353732
E> > 
E> > Log:
E> >  Make rt_getifa_fib() static.
E> 
E> Why should it be made static? The answer to this question is missing from the commit message.

Because a function used only in a scope of a single file and not
intended to be used outside should be made static.

-- 
Gleb Smirnoff