From owner-svn-src-projects@FreeBSD.ORG Wed Jun 24 16:05:15 2009 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B764D1065673; Wed, 24 Jun 2009 16:05:15 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 89A9E8FC0C; Wed, 24 Jun 2009 16:05:15 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 3B52946BA2; Wed, 24 Jun 2009 12:05:15 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 1737F8A079; Wed, 24 Jun 2009 12:05:14 -0400 (EDT) From: John Baldwin To: Ulf Lilleengen Date: Wed, 24 Jun 2009 12:04:50 -0400 User-Agent: KMail/1.9.7 References: <200906241544.n5OFi43Q019124@svn.freebsd.org> In-Reply-To: <200906241544.n5OFi43Q019124@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906241204.51117.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Wed, 24 Jun 2009 12:05:14 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r194847 - projects/libprocstat/sys/sys X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jun 2009 16:05:16 -0000 On Wednesday 24 June 2009 11:44:04 am Ulf Lilleengen wrote: > Author: lulf > Date: Wed Jun 24 15:44:04 2009 > New Revision: 194847 > URL: http://svn.freebsd.org/changeset/base/194847 > > Log: > - Change types to those used internally in the kernel. > - Add kf_status to be used for kinfo-specific flags. > > Modified: > projects/libprocstat/sys/sys/user.h > > Modified: projects/libprocstat/sys/sys/user.h > ============================================================================== > --- projects/libprocstat/sys/sys/user.h Wed Jun 24 15:41:21 2009 (r194846) > +++ projects/libprocstat/sys/sys/user.h Wed Jun 24 15:44:04 2009 (r194847) > @@ -312,6 +312,7 @@ struct kinfo_ofile { > > struct kinfo_file { > int kf_structsize; /* Variable size of record. */ > + uint16_t kf_status; /* Status flags. */ > int kf_type; /* Descriptor type. */ > int kf_fd; /* Array index. */ > int kf_ref_count; /* Reference count. */ > @@ -324,11 +325,11 @@ struct kinfo_file { > int kf_sock_protocol; /* Socket protocol. */ > struct sockaddr_storage kf_sa_local; /* Socket address. */ > struct sockaddr_storage kf_sa_peer; /* Peer address. */ > - uint32_t kf_fsid; /* Vnode filesystem id. */ > - uint64_t kf_fileid; /* Global file id. */ > - uint32_t kf_mode; /* File mode. */ > - int64_t kf_size; /* File size. */ > - uint32_t kf_rdev; /* File device. */ > + dev_t kf_file_fsid; /* Vnode filesystem id. */ > + uint64_t kf_file_fileid; /* Global file id. */ > + mode_t kf_file_mode; /* File mode. */ > + off_t kf_file_size; /* File size. */ > + dev_t kf_file_rdev; /* File device. */ > int _kf_ispare[9]; /* Space for more stuff. */ > /* Truncated before copyout in sysctl */ > char kf_path[PATH_MAX]; /* Path to file, if any. */ You probably don't want to add kf_status where you did as it disturbs the ABI of all the fields after it. New fields should be added in the spare region. Given that mode_t is 16-bits I would just stick it next to kf_file_mode. -- John Baldwin