From owner-p4-projects@FreeBSD.ORG  Thu Oct 18 04:31:30 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 679B116A41B; Thu, 18 Oct 2007 04:31:30 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1682216A417
	for <perforce@freebsd.org>; Thu, 18 Oct 2007 04:31:30 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 03CD613C457
	for <perforce@freebsd.org>; Thu, 18 Oct 2007 04:31:30 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I4VTdM094080
	for <perforce@freebsd.org>; Thu, 18 Oct 2007 04:31:29 GMT
	(envelope-from jb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I4VTCw094077
	for perforce@freebsd.org; Thu, 18 Oct 2007 04:31:29 GMT
	(envelope-from jb@freebsd.org)
Date: Thu, 18 Oct 2007 04:31:29 GMT
Message-Id: <200710180431.l9I4VTCw094077@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jb@freebsd.org using -f
From: John Birrell <jb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 127654 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Oct 2007 04:31:30 -0000

http://perforce.freebsd.org/chv.cgi?CH=127654

Change 127654 by jb@jb_freebsd1 on 2007/10/18 04:31:18

	The FreeBSD kernel has note sections which aren't
	4-byte aligned. I see that tools on other systems assume
	that notes have byte alignment even though the natural
	alignment would be 4 bytes given that's the size of
	the first field in the notes header.
	
	We have to be compatible though, so byte alignment it
	must be.

Affected files ...

.. //depot/projects/dtrace/src/lib/libelf/libelf_align.c#5 edit

Differences ...

==== //depot/projects/dtrace/src/lib/libelf/libelf_align.c#5 (text+ko) ====

@@ -122,7 +122,7 @@
 #endif
 	[ELF_T_MOVEP] 	= UNSUPPORTED(),
 #if	__FreeBSD_version >= 700025
-	[ELF_T_NOTE]	= FALIGN(4,4),
+	[ELF_T_NOTE]	= FALIGN(1,1),
 #endif
 	[ELF_T_OFF]	= FALIGN(4,8),
 	[ELF_T_PHDR]	= FALIGN(4,8),