From owner-cvs-src@FreeBSD.ORG Fri Jun 10 02:32:03 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7687B16A420 for ; Fri, 10 Jun 2005 02:32:03 +0000 (GMT) (envelope-from ups@freebsd.org) Received: from smtp.speedfactory.net (talon.speedfactory.net [66.23.216.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id A8E2E43D4C for ; Fri, 10 Jun 2005 02:32:02 +0000 (GMT) (envelope-from ups@freebsd.org) Received: (qmail 11323 invoked from network); 10 Jun 2005 02:32:01 +0000 Received: from 66-23-216-49.clients.speedfactory.net (HELO palm.tree.com) (66.23.216.49) by smtp.speedfactory.net with AES256-SHA encrypted SMTP; 10 Jun 2005 02:32:01 +0000 Received: from [127.0.0.1] (ups@localhost.tree.com [127.0.0.1]) by palm.tree.com (8.12.10/8.12.10) with ESMTP id j5A2VjpP096334; Thu, 9 Jun 2005 22:31:45 -0400 (EDT) (envelope-from ups@freebsd.org) From: Stephan Uphoff To: Nate Lawson In-Reply-To: <42A8F061.5020201@root.org> References: <200506091943.j59Jh8H3058277@repoman.freebsd.org> <692e14e0d72d5737f1c12f3c8def892d@baldwin.cx> <1118366438.27369.45017.camel@palm> <42A8F061.5020201@root.org> Content-Type: text/plain Message-Id: <1118370705.27369.45598.camel@palm> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Thu, 09 Jun 2005 22:31:45 -0400 Content-Transfer-Encoding: 7bit Cc: John Baldwin , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_switch.c sched_4bsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2005 02:32:03 -0000 On Thu, 2005-06-09 at 21:44, Nate Lawson wrote: > Stephan Uphoff wrote: > > On Thu, 2005-06-09 at 19:25, John Baldwin wrote: > >>On Jun 9, 2005, at 12:43 PM, Stephan Uphoff wrote: > >>>ups 2005-06-09 19:43:08 UTC > >>> > >>> FreeBSD src repository > >>> > >>> Modified files: > >>> sys/kern kern_switch.c sched_4bsd.c > >>> Log: > >>> Lots of whitespace cleanup. > >>> Fix for broken if condition. > >>> > >>> Submitted by: nate@ > >> > >>What was broken about the if test? The intention was that when > >>FULL_PREEMPTION was off, we only preempt if the destination thread is > >>an ithread or if the current thread is an idle priority thread. > > > > I was under the impression that we never preempt the idle thread but did > > not investigate closer. > > > > Is it save to preempt the idle thread on x86 when it does its ACPI > > C-state magic? > > I agree that the idle thread should be pre-empted before the Cx sleep. Sorry - for the confusion. Interrupts are disabled before calling acpi_cpu_idle so this should not be a problem. I will restore the original test. Thanks Stephan