From owner-svn-src-all@freebsd.org Mon Apr 18 18:57:56 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5B87AB131DD; Mon, 18 Apr 2016 18:57:56 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 273C11190; Mon, 18 Apr 2016 18:57:56 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from [192.168.1.102] (p508F0542.dip0.t-ipconnect.de [80.143.5.66]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 98D7B721E280E; Mon, 18 Apr 2016 20:57:53 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r298199 - head/sys/netinet From: Michael Tuexen In-Reply-To: <1461001718.52955.50.camel@freebsd.org> Date: Mon, 18 Apr 2016 20:57:52 +0200 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: <3BCA34A1-0DC4-4DDF-B668-A0DAE8722011@freebsd.org> References: <201604180929.u3I9TEA3095105@repo.freebsd.org> <1460992202.52955.49.camel@freebsd.org> <1461001718.52955.50.camel@freebsd.org> To: Ian Lepore X-Mailer: Apple Mail (2.3124) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2016 18:57:56 -0000 > On 18 Apr 2016, at 19:48, Ian Lepore wrote: > > On Mon, 2016-04-18 at 18:58 +0200, Michael Tuexen wrote: >>> On 18 Apr 2016, at 17:10, Ian Lepore wrote: >>> >>> On Mon, 2016-04-18 at 09:29 +0000, Michael Tuexen wrote: >>>> Author: tuexen >>>> Date: Mon Apr 18 09:29:14 2016 >>>> New Revision: 298199 >>>> URL: https://svnweb.freebsd.org/changeset/base/298199 >>>> >>>> Log: >>>> Put panic() calls under INVARIANTS. >>>> >>> >>> A panic that's only active when INVARIANTS is defined is usually >>> spelled KASSERT. >> OK. The change happens because when using the code in the userland >> SCTP stack, we don't provide a panic() replacement unless we >> compile the INVARIANTS defined. Therefore I catch this when compiling >> the userland stack... >> >> Best regards >> Michael >>> > > Ahh, no KASSERT in userland, thanks. I probably could have figured > that out for myself if I had put a bit of effort into looking. Well, we also have KASSERT in the userland code. All panic() calls in the SCTP code are under INVARIANTS and only the last integrated changes broke with the rule. I detected this when getting these changes into the userland code and therefore I fixed it. I'll try to convert them to KASSERTs sometime in the future. But this has not high priority right now... Thanks for making me aware of it. Best regards Michael > > -- Ian >