From owner-freebsd-net@FreeBSD.ORG Tue Aug 26 19:52:20 2014 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D0CA8992; Tue, 26 Aug 2014 19:52:20 +0000 (UTC) Received: from mail-qc0-x22c.google.com (mail-qc0-x22c.google.com [IPv6:2607:f8b0:400d:c01::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47BFB34A4; Tue, 26 Aug 2014 19:52:20 +0000 (UTC) Received: by mail-qc0-f172.google.com with SMTP id i8so16230906qcq.31 for ; Tue, 26 Aug 2014 12:52:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=J1InMtZnkzQ/WuX4+N9gZo1O/wy0+f6D5hznLe+Szvs=; b=E5zzIpBngIQnMDB9NF2MjjSk8FNzNBAw8C5sk8MlZPSTgpWw6OtqOoVlwyZ2R60mhV K1ZG1mbTPUyU8N6+bJWKCBl+GDTxvvFmVTiydmd9GwO6rkKyaslR+vgeCLR5sNWgQ09V PuUJOM5yoJJYkGkPWsyMFiOY81ZtCF2KC/PVmqOTI6Xntc2ZNwBwYGtixjRrucv0zWdG 2+kQ+XkdtIP4W+x3iDXTRxxkaZ4B0dSbIKLEwzpZ3f+giZSjG448V5Ir8aIylYid973e tYK/yMBvOWMQw8MmjHA7/Uc8HqkMRHWgQ8SnD1m2SujVPhv08jXmNhPBl8C2seziWf1o lD8g== X-Received: by 10.140.89.5 with SMTP id u5mr47597909qgd.14.1409082739298; Tue, 26 Aug 2014 12:52:19 -0700 (PDT) Received: from charmander.home ([64.229.13.35]) by mx.google.com with ESMTPSA id k4sm12392362qaf.0.2014.08.26.12.52.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Aug 2014 12:52:18 -0700 (PDT) Sender: Mark Johnston Date: Tue, 26 Aug 2014 15:51:40 -0400 From: Mark Johnston To: John Baldwin Subject: Re: [PATCH] Packet loss when 'control' messages are present with large data (sendmsg(2)) Message-ID: <20140826195140.GA10143@charmander.home> References: <522300E3.6050303@rawbw.com> <2204059.7tqSNWvxzC@ralph.baldwin.cx> <201408261515.32146.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201408261515.32146.jhb@freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: current@freebsd.org, Alan Somers , Harald Schmalzbauer , FreeBSD CURRENT , "net@freebsd.org" , Yuri X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2014 19:52:21 -0000 On Tue, Aug 26, 2014 at 03:15:31PM -0400, John Baldwin wrote: > On Tuesday, August 26, 2014 11:05:12 am Alan Somers wrote: > > On Mon, Aug 25, 2014 at 1:52 PM, John Baldwin wrote: > > > On Friday, August 22, 2014 01:34:28 PM Harald Schmalzbauer wrote: > > >> Bezüglich Yuri's Nachricht vom 02.09.2013 06:54 (localtime): > > >> > Please check in this patch: > > >> > http://www.freebsd.org/cgi/query-pr.cgi?pr=181741 > > >> > Please MFC into 9.X > > >> > > > >> > Description of the problem is within PR. > > >> > > > >> > Thanks, > > >> > Yuri > > >> > > >> Hello, > > >> > > >> I guess this fix should make it into 10.1. > > >> Can someone check please? > > > > > > A fix has to make into HEAD first. I've cc'd Alan who responded to the bug. > > > Alan, note that glebius@ already committed the test case to HEAD a while ago. > > > > First, Gleb's testcase needs to be converted to ATF. This would be a > > good exercise for anybody who's new to ATF and wants some practice. > > Anybody interested? > > While that would be nice, I don't know that it's quite fair to require the > test to be converted before working on a possible fix. The existing test > doesn't seem that hard to run by hand: > > % cd work/freebsd/head/tools/regression/sockets/unix_passfd/ > % make > ... > % > ./unix_passfd > beginning test1-simplesendfd > test1-simplesendfd passed > ... > beginning test8-rigths+creds+payload > unix_passfd: test8-rigths+creds+payload: recvmsg: 24 bytes received > > I only say this because in the bug followup you seemed to have described a > possible solution so it seems that you would be able to develop a fix quicker > than other folks since you are already familiar with the issues involved. > (Also, you've fixed other related issues recently.) As it happens, I went ahead and did this anyway: https://reviews.freebsd.org/D689