From owner-svn-src-head@freebsd.org Wed Jul 8 22:04:39 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 340059964C5; Wed, 8 Jul 2015 22:04:39 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x22f.google.com (mail-ig0-x22f.google.com [IPv6:2607:f8b0:4001:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0001D1EE4; Wed, 8 Jul 2015 22:04:38 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by igrv9 with SMTP id v9so178906633igr.1; Wed, 08 Jul 2015 15:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=HeYWx4jhzc6hjwutBGfDygJxcKovOZY5A0gzKLymSF4=; b=VlLGWuVBIAEO2NRCzEkqBNP+FupzDp0b9310EJEIsx5LLph+r/gXAS/PlyuTDyyv+f i9EXpgUQZ/3VLHsWVAlQ1aevnM1LwqCONo+Ue/F8kaMJrANh6qTdYfrIrxl+qUN9DorT PYUXYDolJmBR4sSUYKiaI0ThHpa5hvwI8omdii/8fnTc47m/KZDS6TE4dz4/m8lBIDbO 2sxobr+e7hTNfW0f+fC23Em/ArOJlrxUNzFCGRS2i2V9Ywx3ad3Emi63gFrLvUaEQVNJ Xe2jw+aO8Zy0aFbvSjXjltxcVnKuZyXKXjwYLp9u11/ymgPbFY8EY5gwTZ8WyiDKILxL vkWw== MIME-Version: 1.0 X-Received: by 10.107.155.74 with SMTP id d71mr20918496ioe.29.1436393078300; Wed, 08 Jul 2015 15:04:38 -0700 (PDT) Received: by 10.36.38.133 with HTTP; Wed, 8 Jul 2015 15:04:38 -0700 (PDT) In-Reply-To: <559D9172.9040305@FreeBSD.org> References: <201507081836.t68IacJu069563@repo.freebsd.org> <559D9172.9040305@FreeBSD.org> Date: Wed, 8 Jul 2015 15:04:38 -0700 Message-ID: Subject: Re: svn commit: r285284 - head/lib/liblzma From: Adrian Chadd To: Pedro Giffuni Cc: Luigi Rizzo , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 22:04:39 -0000 Is there a blessed way to see whether the compiler we're using is an external compiler, or an internal one? eg, the version check isn't enough - it's just a number. how do I know if it's freebsd clang versus upstream clang? (Or in my instance, freebsd-gcc versus upstream-gcc.) -a On 8 July 2015 at 14:09, Pedro Giffuni wrote: > > > On 07/08/15 13:36, Luigi Rizzo wrote: >> >> Author: luigi >> Date: Wed Jul 8 18:36:37 2015 >> New Revision: 285284 >> URL: https://svnweb.freebsd.org/changeset/base/285284 >> >> Log: >> only enable immintrin when clang is used. The base gcc does not support >> it. >> Reviewed by: delphij >> >> Modified: >> head/lib/liblzma/config.h >> >> Modified: head/lib/liblzma/config.h >> >> ============================================================================== >> --- head/lib/liblzma/config.h Wed Jul 8 18:12:24 2015 (r285283) >> +++ head/lib/liblzma/config.h Wed Jul 8 18:36:37 2015 (r285284) >> @@ -150,7 +150,8 @@ >> #define HAVE_ICONV 1 >> /* Define to 1 if you have the header file. */ >> -#if defined(__FreeBSD__) && defined(__amd64__) >> +/* FreeBSD - only with clang because the base gcc does not support it */ >> +#if defined(__clang__) && defined(__FreeBSD__) && defined(__amd64__) >> #define HAVE_IMMINTRIN_H 1 >> #endif >> > > FWIW, gcc 4.3+ does have it so this may some undesired (but hidden) > effect when building with an external gcc. > > Pedro. >