From owner-cvs-sys Fri Nov 7 06:15:36 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id GAA01161 for cvs-sys-outgoing; Fri, 7 Nov 1997 06:15:36 -0800 (PST) (envelope-from owner-cvs-sys) Received: from critter.freebsd.dk (critter.freebsd.dk [195.8.129.26]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id GAA01154; Fri, 7 Nov 1997 06:15:19 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost.cybercity.dk [127.0.0.1]) by critter.freebsd.dk (8.8.7/8.8.7) with ESMTP id PAA02570; Fri, 7 Nov 1997 15:13:52 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Eivind Eklund cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 machdep.c pmap.c src/sys/i386/isa if_zp.c ncr5380.c seagate.c syscons.c wd.c src/sys/kern subr_diskslice.c src/sys/libkern qdivrem.c src/sys/netinet ip_output.c src/sys/nfs nfs_vnops.c src/sys/pci ncr.c src/sys/vm ... In-reply-to: Your message of "Fri, 07 Nov 1997 15:09:48 +0100." <199711071409.PAA07017@bitbox.follo.net> Date: Fri, 07 Nov 1997 15:13:51 +0100 Message-ID: <2568.878912031@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message <199711071409.PAA07017@bitbox.follo.net>, Eivind Eklund writes: >[...] >> Log: >> Rename some local variables to avoid shadowing other local variables. >> >> Found by: -Wshadow > >If you've fixed all of these, would it be a good idea to add -Wshadow >and -Wunused to the Makefile flags? Well, I just took the easy ones, there are plenty still to go. For -Wunused, many variables should go under some #ifdef FOOMBLE option which is present i LINT but not in GENERIC For -Wshadow, there are some not quite easy to fix systematic shadowing going on. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop."