From owner-svn-src-all@freebsd.org Mon Mar 6 18:18:30 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF285CFBD35 for ; Mon, 6 Mar 2017 18:18:30 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm22-vm4.bullet.mail.ne1.yahoo.com (nm22-vm4.bullet.mail.ne1.yahoo.com [98.138.91.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8B8F71151 for ; Mon, 6 Mar 2017 18:18:30 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1488823943; bh=4DCIN9C5erGG9CGIAWzx2hEmu5CTQMlYIm36dfdKeZU=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=BpIBTcZhBola98DbKU6FC6tHin4eH7Ccmi6ZptHEO7NNPVcGpslbhuLyOKGKiFO9lmYjXAzrbo6VUOa7mTjv6GVGzRBY85WEqpJq+X8RfwmPimMfLMjc8OpBoUIAXc3hju3Lzs4HaQRPT15mfqvpUKY0OTiZSBDrInlZltkKpcsUHIIIYK8pSjCJObgwEpb5d2FuZ7DT6IcvylXvcD9H+zCutHF8arfhknqvk4hUU7aqDdy3Ey0WzGSunUKcMtOmyLFwYD45QPwGCFE10mGcldMTMtPUMwOVvFhXCOZUXpuXd9NmX3jb4B/jhQU5ROjQ9q0EAY4PMqwZFY5wUxT76w== Received: from [98.138.100.113] by nm22.bullet.mail.ne1.yahoo.com with NNFMP; 06 Mar 2017 18:12:23 -0000 Received: from [98.138.84.46] by tm104.bullet.mail.ne1.yahoo.com with NNFMP; 06 Mar 2017 18:12:23 -0000 Received: from [127.0.0.1] by smtp114.mail.ne1.yahoo.com with NNFMP; 06 Mar 2017 18:12:23 -0000 X-Yahoo-Newman-Id: 521401.28967.bm@smtp114.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: ZpGXSB4VM1nMFuAObc9MhaDfgmxKoxHuLQhSGpKMgQcYxEz _ru39bAwizjDWgCvTLBd7O.XqQfuAcW8BRzYlUXtYd7.ilyIQ4ruZs8WOW8L EVMAW5xF2fgccwgQOIaZpHwTZZpG03cvQDTD9pmJhO2OOdeIbTi0shga8VZW i96XW7BIeobCM4QKa06vqx3y7W1DmmZjXGTUdUBMjs.D9xQs_fJJ7pjTiVZL l6aM_i7nBzkIG6DmripnXIuGuL7FW6Z7accJ2Jnuh3rYnfKvuaU1CK1Z6GHT jkpGGwN5iTtkoic.IqHK4LWzfJNsWqtmf_z7RPEytgB9aTAUyNHCZmnCWZ34 cBZ6HNNjV.fvZXf1mPYRz9eNn.9ddt_igBiiDRqKqtCeS4vUdfgdVCowpqEc o0rBI1oE_6SXbwoVMa1PZbQIMC3GHlRuKpwI39bLx8we0vfnoVD3QRtUB2cG qgI7zTrYI7cAnu2NcxnlPBjI5JEMr9s8aimY4lnVCjS61_9PZoickpvp3qWA joDcedZ_PZpFBmbI3lzV4KCl6T7B9MZAX6PrLdGBJ8jAUrq8- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r314778 - head/lib/libfetch To: Baptiste Daroussin References: <201703061538.v26Fc33J022910@repo.freebsd.org> <20170306154419.psguuxspco3hgw64@ivaldir.net> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Pedro Giffuni Message-ID: <9e86f0a7-c24b-2bda-e289-02bacb699c72@FreeBSD.org> Date: Mon, 6 Mar 2017 13:15:21 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170306154419.psguuxspco3hgw64@ivaldir.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 18:18:30 -0000 Hi; On 3/6/2017 10:44 AM, Baptiste Daroussin wrote: > On Mon, Mar 06, 2017 at 03:38:03PM +0000, Pedro F. Giffuni wrote: >> Author: pfg >> Date: Mon Mar 6 15:38:03 2017 >> New Revision: 314778 >> URL: https://svnweb.freebsd.org/changeset/base/314778 >> >> Log: >> libfetch: extra bounds checking through reallocarray(3). >> >> Reviewed by: des >> MFC after: 1 week >> >> Modified: >> head/lib/libfetch/common.c >> >> Modified: head/lib/libfetch/common.c >> ============================================================================== >> --- head/lib/libfetch/common.c Mon Mar 6 15:37:34 2017 (r314777) >> +++ head/lib/libfetch/common.c Mon Mar 6 15:38:03 2017 (r314778) >> @@ -1306,7 +1306,7 @@ fetch_add_entry(struct url_ent **p, int >> } >> >> if (*len >= *size - 1) { >> - tmp = realloc(*p, (*size * 2 + 1) * sizeof(**p)); >> + tmp = reallocarray(*p, *size * 2 + 1, sizeof(**p)); > It reduces portability of libfetch (which pkg depends on) I can probably add an > implementation of reallocarry in pkg itself. This is an unavoidable consequence of adding functions to libc: we may find uses for them. Pedro.