From owner-freebsd-bugs@FreeBSD.ORG Wed Apr 5 17:40:20 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3BBD416A401 for ; Wed, 5 Apr 2006 17:40:20 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5880E43D45 for ; Wed, 5 Apr 2006 17:40:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k35HeHNQ039315 for ; Wed, 5 Apr 2006 17:40:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k35HeHZS039314; Wed, 5 Apr 2006 17:40:17 GMT (envelope-from gnats) Resent-Date: Wed, 5 Apr 2006 17:40:17 GMT Resent-Message-Id: <200604051740.k35HeHZS039314@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stephen Corteselli Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13C2A16A41F for ; Wed, 5 Apr 2006 17:31:48 +0000 (UTC) (envelope-from sc@xilinxpc.ho.lucent.com) Received: from hoemail1.lucent.com (hoemail1.lucent.com [192.11.226.161]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3DF7D43D4C for ; Wed, 5 Apr 2006 17:31:47 +0000 (GMT) (envelope-from sc@xilinxpc.ho.lucent.com) Received: from homail.ho.lucent.com (h135-17-192-10.lucent.com [135.17.192.10]) by hoemail1.lucent.com (8.12.11/8.12.11) with ESMTP id k35HVj0G006473 for ; Wed, 5 Apr 2006 12:31:45 -0500 (CDT) Received: from xilinxpc.ho.lucent.com (xilinxpc.ho.lucent.com [135.112.126.43]) by homail.ho.lucent.com (8.11.7p1+Sun/EMS-1.5 sol2) id k35HVj625015; Wed, 5 Apr 2006 13:31:45 -0400 (EDT) Received: from xilinxpc.ho.lucent.com (localhost [127.0.0.1]) by xilinxpc.ho.lucent.com (8.13.1/8.13.1) with ESMTP id k35HVKa9014189 for ; Wed, 5 Apr 2006 13:31:20 -0400 (EDT) (envelope-from sc@xilinxpc.ho.lucent.com) Received: (from sc@localhost) by xilinxpc.ho.lucent.com (8.13.1/8.13.1/Submit) id k35HVKhu014188; Wed, 5 Apr 2006 13:31:20 -0400 (EDT) (envelope-from sc) Message-Id: <200604051731.k35HVKhu014188@xilinxpc.ho.lucent.com> Date: Wed, 5 Apr 2006 13:31:20 -0400 (EDT) From: Stephen.Corteselli@xilinxpc.ho.lucent.com To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/95357: knlist of vmnet device is incorrectly destroyed by tapclose() X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Stephen Corteselli List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2006 17:40:20 -0000 >Number: 95357 >Category: kern >Synopsis: knlist of vmnet device is incorrectly destroyed by tapclose() >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Apr 05 17:40:17 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Stephen Corteselli >Release: FreeBSD 7.0-CURRENT i386 >Organization: >Environment: System: FreeBSD FreeBSD 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Sun Apr 2 21:34:14 EDT 2006 sc@FreeBSD:/usr/sys/i386/compile/SC i386 >Description: In sys/net/if_tap.c 1.59 2006/03/16, tapclose() unconditionally destroys the knlist initialized in tapopen(). However, the vmnet device uses the knlist after tapclose is called. This causes a panic when ifconfig'ing vmnet1 with an IP address. (if_tap.ko is needed to run the VMware 2 port.) >How-To-Repeat: kldload if_tap.ko echo -n >/dev/vmnet1 ifconfig vmnet1 1.1.1.1 >Fix: I'm not sure what the proper fix is, but I got ifconfig not to panic the system by moving the call to knlist_destroy() (line 462 of sys/net/if_tap.c) to just before line 449 (i.e., in the if statement executed if this is NOT the vmnet device. >Release-Note: >Audit-Trail: >Unformatted: