From owner-dev-commits-src-main@freebsd.org  Mon Aug 16 16:53:38 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 07FD565101C;
 Mon, 16 Aug 2021 16:53:38 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4GpKxF6tQMz4nxK;
 Mon, 16 Aug 2021 16:53:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx
 [66.234.199.215])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate) (Authenticated sender: jhb)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 6A551482F;
 Mon, 16 Aug 2021 16:53:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Subject: Re: git: 8f63fa78e84a - main - rtld: Remove calculate_tls_end
To: Konstantin Belousov <kib@FreeBSD.org>, src-committers@FreeBSD.org,
 dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
References: <202108161056.17GAuFNC017048@gitrepo.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <36c06d31-503b-121b-ca58-ad3f99bda22b@FreeBSD.org>
Date: Mon, 16 Aug 2021 09:53:35 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <202108161056.17GAuFNC017048@gitrepo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Aug 2021 16:53:38 -0000

On 8/16/21 3:56 AM, Konstantin Belousov wrote:
> The branch main has been updated by kib:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=8f63fa78e84afd23fa68c82eabfe64763c92d4f5
> 
> commit 8f63fa78e84afd23fa68c82eabfe64763c92d4f5
> Author:     Fangrui Song <i@maskray.me>
> AuthorDate: 2021-08-14 17:02:09 +0000
> Commit:     Konstantin Belousov <kib@FreeBSD.org>
> CommitDate: 2021-08-16 10:55:35 +0000
> 
>      rtld: Remove calculate_tls_end
>      
>      Variant I architectures use off and Variant II ones use size + off.
>      Define TLS_VARIANT_I/TLS_VARIANT_II symbols similarly to how libc
>      handles it.
>      
>      Reviewed by:    kib
>      MFC after:      1 week
>      Differential revision:  https://reviews.freebsd.org/D31539
>      Differential revision:  https://reviews.freebsd.org/D31541

Would it make sense to have <machine/tls.h> and move the TLS-related
constants there?  Right now we duplicate them in at least two places
(libthr internal headers and libc/rtld).

-- 
John Baldwin