Date: Tue, 07 Dec 2010 20:08:39 +0000 From: "Tom Judge" <tom@tomjudge.com> To: FreeBSD-gnats-submit@FreeBSD.org Cc: jpaetzel@FreeBSD.org Subject: ports/152901: [patch] databases/pecl-sqlite Cleanup/Fixes Message-ID: <20101207200635.1C66448C10@tomjudge.vm.bytemark.co.uk> Resent-Message-ID: <201012072010.oB7KA9vI059933@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 152901
>Category: ports
>Synopsis: [patch] databases/pecl-sqlite Cleanup/Fixes
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Dec 07 20:10:08 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Tom Judge
>Release: FreeBSD 8.1-STABLE amd64
>Organization:
>Environment:
System: FreeBSD tinderbox.home.tomjudge.com 8.1-STABLE FreeBSD 8.1-STABLE #0 r213720: Tue Oct 12 14:02:02 UTC 2010 tj@tinderbox.home.tomjudge.com:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
The attached patch fixes the following issues with databases/pecl-sqlite which is the api for sqlite in php 4:
* The port did not define DEFAULT_PHP_VER to 4 so pakcage building is broken.
* The port did not have the correct IGNORE set for the new dual 5.3 and 5.2 ports. Remove the .if block and add an IGNORE_WITH_PHP.
* Update the comment to reflect the fact that this port is for php 4 only.
* Remove the MD5 line from distinfo.
>How-To-Repeat:
>Fix:
--- databases-pecl-sqlite.txt begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/databases/pecl-sqlite/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile 16 Sep 2005 17:58:26 -0000 1.4
+++ Makefile 7 Dec 2010 20:03:38 -0000
@@ -15,7 +15,7 @@
DIST_SUBDIR= PECL
MAINTAINER= mnag@FreeBSD.org
-COMMENT= PECL classes to access sqlite databases
+COMMENT= PECL classes to access sqlite databases in PHP 4
WRKSRC= ${WRKDIR}/SQLite-${PORTVERSION}
PKGMESSAGE= ${WRKDIR}/pkg-message
@@ -24,6 +24,8 @@
USE_PHPIZE= yes
USE_PHPEXT= yes
PHP_MODNAME= sqlite
+DEFAULT_PHP_VER=4
+IGNORE_WITH_PHP=5 52
CONFIGURE_ARGS= --with-sqlite
@@ -32,10 +34,6 @@
.include <bsd.port.pre.mk>
-.if ${PHP_VER} == 5
-IGNORE= Please use databases/php${PHP_VER}-sqlite
-.endif
-
.if !defined(NOPORTDOCS)
PORTDOCS= *
.endif
Index: distinfo
===================================================================
RCS file: /home/ncvs/ports/databases/pecl-sqlite/distinfo,v
retrieving revision 1.3
diff -u -r1.3 distinfo
--- distinfo 9 Nov 2005 02:32:44 -0000 1.3
+++ distinfo 7 Dec 2010 16:58:45 -0000
@@ -1,3 +1,2 @@
-MD5 (PECL/SQLite-1.0.3.tgz) = 3741cb211f9eb3f77de086e96d232e95
SHA256 (PECL/SQLite-1.0.3.tgz) = 19edf52557c75a764e021d60414fe4ce347cbdab55377d4aafbecb30785d79a5
SIZE (PECL/SQLite-1.0.3.tgz) = 371189
--- databases-pecl-sqlite.txt ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101207200635.1C66448C10>