From owner-freebsd-bugs@FreeBSD.ORG Fri Dec 2 12:40:42 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7699B16A420 for ; Fri, 2 Dec 2005 12:40:42 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id AFA1E43D79 for ; Fri, 2 Dec 2005 12:40:03 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jB2Ce3u2016658 for ; Fri, 2 Dec 2005 12:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jB2Ce3JZ016657; Fri, 2 Dec 2005 12:40:03 GMT (envelope-from gnats) Resent-Date: Fri, 2 Dec 2005 12:40:03 GMT Resent-Message-Id: <200512021240.jB2Ce3JZ016657@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jeremy Chadwick Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 848DF16A41F for ; Fri, 2 Dec 2005 12:32:53 +0000 (GMT) (envelope-from jdc@koitsu.dyndns.org) Received: from ylpvm29.prodigy.net (ylpvm29-ext.prodigy.net [207.115.57.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id E853A43D58 for ; Fri, 2 Dec 2005 12:32:52 +0000 (GMT) (envelope-from jdc@koitsu.dyndns.org) Received: from pimout6-ext.prodigy.net (pimout6-int.prodigy.net [207.115.4.22]) by ylpvm29.prodigy.net (8.12.10 outbound/8.12.10) with ESMTP id jB2CX3to001394 for ; Fri, 2 Dec 2005 07:33:03 -0500 Received: from icarus.home.lan (adsl-71-141-104-33.dsl.snfc21.pacbell.net [71.141.104.33]) by pimout6-ext.prodigy.net (8.13.4 outbound domainkey aix/8.13.4) with ESMTP id jB2CWk8U129164 for ; Fri, 2 Dec 2005 07:32:47 -0500 Received: by icarus.home.lan (Postfix, from userid 1000) id 24E545C033; Fri, 2 Dec 2005 04:32:46 -0800 (PST) Message-Id: <20051202123246.24E545C033@icarus.home.lan> Date: Fri, 2 Dec 2005 04:32:46 -0800 (PST) From: Jeremy Chadwick To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/89837: PCI code outputs superfluous "failed to enable/disable memory/port mapping!" messages X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jeremy Chadwick List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2005 12:40:42 -0000 >Number: 89837 >Category: kern >Synopsis: PCI code outputs superfluous "failed to enable/disable memory/port mapping!" messages >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Dec 02 12:40:02 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Jeremy Chadwick >Release: FreeBSD 6.0-STABLE i386 >Organization: Parodius Networking >Environment: System: FreeBSD icarus.home.lan 6.0-STABLE FreeBSD 6.0-STABLE #0: Fri Dec 2 02:22:17 PST 2005 root@icarus.home.lan:/usr/obj/usr/src/sys/ICARUS i386 >Description: The PCI code can under many configurations spit out the following kernel message: XXXpciXXX: failed to {enable|disable} {memory|port} mapping! This is output via device_printf() in sys/dev/pci/pci.c, lines ~677 and ~706. There have been numerous PRs and mailing list threads about what this message means (particularly the "failed to enable memory mapping!" message). So far, every report I've seen that involves driver developers results in them saying "This message should only appear when bootverbose is enabled, so ignore it." I'm proposing that the above device_printf() calls be wrapped with a bootverbose check -- and ONLY for the device_printf() (not the return()). I'm sure there will be someone who will step up and say why this is a bad idea, blah blah blah, but I'll remind you that such messages on -STABLE need only appear when there _really_ is a problem, and not when "there isn't a problem but it's nice to know"; messages of this nature should be left for -CURRENT. If it's _really_ necessary, then users need something that explains what this message actually means (one can find such explanations in certain manpages, such as bge(4) -- but, at least in my case, it seems unlikely that my Intel ICH5 Southbridge, on an Intel motherboard nonetheless, would lack bus-mastering support :-) ). >How-To-Repeat: Not applicable. >Fix: Wrap the device_printf() statements in sys/dev/pci/pci.c which output the aforementioned message with an "if (bootverbose)" conditional. I can provide a patch if someone doesn't want to deal with doing it. This matter should apply to both 5.x and 6.x kernels (and probably 7.x too). >Release-Note: >Audit-Trail: >Unformatted: