From owner-svn-ports-all@FreeBSD.ORG  Wed Jul  2 11:58:23 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id AB53A29A;
 Wed,  2 Jul 2014 11:58:23 +0000 (UTC)
Received: from mailrelay008.isp.belgacom.be (mailrelay008.isp.belgacom.be
 [195.238.6.174])
 by mx1.freebsd.org (Postfix) with ESMTP id F209E2C5C;
 Wed,  2 Jul 2014 11:58:22 +0000 (UTC)
X-Belgacom-Dynamic: yes
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AsUGAOHys1NbsKhu/2dsb2JhbABagw1SsFuWHAGBCxd1hAMBAQU6HCMQCxgJJQ8qHgaIWQHFfReObzMHhEMBBI4XjFWBSYZHi3qDRTs
Received: from 110.168-176-91.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([91.176.168.110])
 by relay.skynet.be with ESMTP; 02 Jul 2014 13:57:12 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id s62BvAoZ002328;
 Wed, 2 Jul 2014 13:57:11 +0200 (CEST)
 (envelope-from tijl@FreeBSD.org)
Date: Wed, 2 Jul 2014 13:57:10 +0200
From: Tijl Coosemans <tijl@FreeBSD.org>
To: Gerald Pfeifer <gerald@pfeifer.com>
Subject: Re: svn commit: r336343 - in head: . Mk/Uses
Message-ID: <20140702135710.52876211@kalimero.tijl.coosemans.org>
In-Reply-To: <alpine.LSU.2.11.1406292318140.30120@tuna.site>
References: <201312131322.rBDDMWZC038800@svn.freebsd.org>
 <alpine.LSU.2.11.1406292318140.30120@tuna.site>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jul 2014 11:58:23 -0000

On Sun, 29 Jun 2014 23:19:33 +0200 (CEST) Gerald Pfeifer wrote:
> On Fri, 13 Dec 2013, Tijl Coosemans wrote:
>> Added: head/Mk/Uses/fortran.mk
>> ==============================================================================
>> +.if ${fortran_ARGS} == gcc
>> +_GCC_VER=	46
> 
> We have already made this ${GCC_DEFAULT:S/.//}...
> 
>> +BUILD_DEPENDS+=	gfortran${_GCC_VER}:${PORTSDIR}/lang/gcc
>> +RUN_DEPENDS+=	gfortran${_GCC_VER}:${PORTSDIR}/lang/gcc
>> +USE_BINUTILS=	yes
>> +F77=		gfortran${_GCC_VER}
>> +FC=		gfortran${_GCC_VER}
>> +FFLAGS+=	-Wl,-rpath=${LOCALBASE}/lib/gcc${_GCC_VER}
>> +LDFLAGS+=	-Wl,-rpath=${LOCALBASE}/lib/gcc${_GCC_VER}
> 
> ...but is there a way to avoid this duplication of logic in bsd.gcc.mk
> (and Uses/compiler)?

For *FLAGS it would be ideal if we didn't need them at all.  If
"gcc49 -o test test.c" would just work I think they can be removed from
bsd.gcc.mk.  In fortran.mk they probably need to stay because some ports
link gfortran object files using "${CC}" or "${CXX}" which may be clang.

There's another problem though, with the *_DEPENDS lines.  They depend
on lang/gcc unconditionally while GCC_DEFAULT is supposed to be a user
tunable.  The dependency should be on lang/gcc${_GCC_VER}, but then
${_GCC_VER} and ${GCC_DEFAULT} would have to be empty to depend on
lang/gcc which is awkward.  Would it be possible to get rid of lang/gcc
by moving it to lang/gcc47?  That would make the gcc ports similar to
the other ports that use the default-versions system like lang/perlXYZ
or www/apacheXY etc.