From nobody Tue Jul 7 06:38:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gvWlf6DTnz6l13V for ; Tue, 07 Jul 2026 06:38:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gvWlf4169z425d for ; Tue, 07 Jul 2026 06:38:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783406334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oze6MFeqtzDpesDJOAmQC/OivHORFcCqxcBjaHFLJGI=; b=bN9iCieHkN3oPL/JNRZSzQKptYzJ4mDD/bkdWIDqU+nSouN2/So3PIP66Ko8qzAUB/mJTo iGQ9Ff+HFprgB6VBH+wBfIAWIriUxkSSq8gmQbQFfS18tIVijAW5evAm4c7F9V4fCpEcgj 3Bx5WXWf3VO25z2N2Dah2FnttEK5KLWz6gAfl9/1p4xlEzBr5kGBQ+tghPsAS3UjeQSXvz Pdda5QevAjVSRLL1mxAwd3Da2w3IHhq1ufIjVT4nqPVyLCGZnUW7cFwda+ufMaBD3y0enc KSZSRxr3HTFqkF6PAyGCR+19EL7yxuu+ALa2BDlim++0VE4GHRDreHUKwJfLdA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783406334; a=rsa-sha256; cv=none; b=efPVhBM1VDjfnWS4v5j9dlA8DNjgb3xt4z4+m3FYfU9Ra+4KMXOoQyNmvlkwXqnZtlHW5i C0Z3bM9A5AKNA5qq2gumL+zDE4HYzuiEfO3URxLPJC2oVeLP6ywBRgMir3Csim98Xt+YKm MLSQFMYahPlP5qB955ij0ZQqmfLZ11PSABfwNzkI/j84SDtxL21eSdwF2WluAMZVpSwhqd lzyHQh/NGBvlfj7CWp1XhdclTyE4A1PoP7Lv/TN5rz1lSDD2pNHslyzObrjtW2w9Yz/aK+ lkFQiO14C9lEKVxf5dvYCVMdW7o5bq8xs05sY+INp0SNNIfMFPG1zwx8Un3XDQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783406334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oze6MFeqtzDpesDJOAmQC/OivHORFcCqxcBjaHFLJGI=; b=m2vbRKrYsUKF/GKRFN5Ss644E7bvb45G+o7KT7n3s8C6UiVdLczizvsRfP8f9NIsdkMtav piyNHGkr6TEvVYA+O+X0EMXsTEV8R/H0IT9bL0KmvrcVXpAkv7TLW3xni5E17q2mUbeQ3F czkxmjoFdFVDrsR7ZKUYYISyJXbc619FhyIhLu3Fu5rS3mdv/Ehjx2F54uaTLzp+CKsGau RbUKWEB+8eAnhhZbjjl2qo1LZaazoiwloo0X+mKqnfvLwPVYV4UYEtMibCfHddQmt7FtkL 2z+fK5/I5W1bX7o34VibQfopDSooB+VmpIKAeND/CC38tX58QXmQrwHnNuyiPw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gvWlf2mkgz6pm for ; Tue, 07 Jul 2026 06:38:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36c14 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 07 Jul 2026 06:38:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 25a3e5046ebd - stable/14 - rc.d/ddb: Really silently exit List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 25a3e5046ebd82c5d0857f73b35ab720be6290a0 Auto-Submitted: auto-generated Date: Tue, 07 Jul 2026 06:38:54 +0000 Message-Id: <6a4c9efe.36c14.16cc8805@gitrepo.freebsd.org> The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=25a3e5046ebd82c5d0857f73b35ab720be6290a0 commit 25a3e5046ebd82c5d0857f73b35ab720be6290a0 Author: Dag-Erling Smørgrav AuthorDate: 2026-06-26 14:38:58 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-07-07 06:38:16 +0000 rc.d/ddb: Really silently exit The comment says “silently exit if ddb is not enabled”, but we'd exit with an error message. Note that I switched the sysctl variable used to test for the presence of ddb from debug.ddb.scripting.scripts to d.d.s.script, which has a smaller value if set. While here, drop a pointless fork-exec, and use ${SYSCTL_N} for consistency. PR: 177217 MFC after: 1 week Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D57686 (cherry picked from commit b0d3a2889a1b8e4b73ad1f396884224e1442b214) --- libexec/rc/rc.d/ddb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libexec/rc/rc.d/ddb b/libexec/rc/rc.d/ddb index 40235bebf90e..cbd821fa522f 100755 --- a/libexec/rc/rc.d/ddb +++ b/libexec/rc/rc.d/ddb @@ -20,8 +20,8 @@ stop_cmd=":" ddb_prestart() { # Silently exit if ddb is not enabled - if [ -z "`sysctl -Nq debug.ddb.scripting.scripts`" ]; then - return 1 + if ! ${SYSCTL_N} -q debug.ddb.scripting.script >/dev/null; then + exit 1 fi }