From owner-freebsd-audit Sat Mar 16 1:21:43 2002 Delivered-To: freebsd-audit@freebsd.org Received: from sunny.newgold.net (durham-ar1-174-172.durham.dsl.gtei.net [4.40.174.172]) by hub.freebsd.org (Postfix) with ESMTP id C5AEF37B404; Sat, 16 Mar 2002 01:21:38 -0800 (PST) Received: from sunny.newgold.net (freebsd@localhost [IPv6:::1]) by sunny.newgold.net (8.12.1/8.12.1) with ESMTP id g2G91SDF010985; Sat, 16 Mar 2002 09:02:50 GMT Received: (from freebsd@localhost) by sunny.newgold.net (8.12.1/8.12.1/Submit) id g2G91QXp020606; Sat, 16 Mar 2002 09:01:26 GMT Date: Sat, 16 Mar 2002 09:00:04 +0000 From: "J. Mallett" To: "Tim J. Robbins" Cc: "J. Mallett" , freebsd-audit@FreeBSD.ORG Subject: Re: patch for review: xargs standards compliance Message-ID: <20020316090004.A26394@FreeBSD.ORG> References: <20020315231100.A20942@FreeBSD.ORG> <20020316192629.A5254@descent.robbins.dropbear.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020316192629.A5254@descent.robbins.dropbear.id.au> User-Agent: Mutt/1.3.21i Organisation: FreeBSD Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Mar 16, 2002 at 07:26:29PM +1100, Tim J. Robbins wrote: > On Fri, Mar 15, 2002 at 11:11:00PM +0000, J. Mallett wrote: > > > In detail, it adds: -E, -I, -L, -t; As far as flags go. > > > > I'm looking to commit this after the weekend, so review would be > > appreciated, comments and flames welcome... Three days sound good? > > Check that the way -I handles empty strings (xargs -I "") is what you > intend. Solaris checks that the argument is not empty: > xargs: Must specify subargment for -I Solaris not recognising that '' and "" are arguments is probably a difference in getopt implementations? We don't check for -J, should I really try to check for -I? I'm happy to, I just don't know if this is standard practice, and so on. Thanks /j. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message