From owner-svn-src-stable-10@FreeBSD.ORG Thu Aug 21 22:42:30 2014 Return-Path: Delivered-To: svn-src-stable-10@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 991C9B4F; Thu, 21 Aug 2014 22:42:30 +0000 (UTC) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6BD433071; Thu, 21 Aug 2014 22:42:30 +0000 (UTC) Received: from [73.34.117.227] (helo=ilsoft.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1XKb3s-00043W-QN; Thu, 21 Aug 2014 22:42:28 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id s7LMgRMr057094; Thu, 21 Aug 2014 16:42:27 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19eofEmCMy9GHwgXfQ0zoMq X-Authentication-Warning: paranoia.hippie.lan: Host revolution.hippie.lan [172.22.42.240] claimed to be [172.22.42.240] Subject: Re: svn commit: r270306 - stable/10/sys/modules/aic7xxx/ahc/ahc_eisa From: Ian Lepore To: src-committers@freebsd.org In-Reply-To: <201408212136.s7LLa7cu001694@svn.freebsd.org> References: <201408212136.s7LLa7cu001694@svn.freebsd.org> Content-Type: text/plain; charset="us-ascii" Date: Thu, 21 Aug 2014 16:42:27 -0600 Message-ID: <1408660947.1150.37.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, svn-src-stable-10@freebsd.org X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Aug 2014 22:42:30 -0000 On Thu, 2014-08-21 at 21:36 +0000, Ian Lepore wrote: > Author: ian > Date: Thu Aug 21 21:36:06 2014 > New Revision: 270306 > URL: http://svnweb.freebsd.org/changeset/base/270306 > > Log: > This module requires pci_if.h, add it to the SRCS list. > > We haven't noticed that it was missing because eisa has been disabled for > a while in -current, but it became apparent when some parallel-build stuff > was MFC'd to 10-stable and this module failed to build there. > > Modified: > stable/10/sys/modules/aic7xxx/ahc/ahc_eisa/Makefile > > Modified: stable/10/sys/modules/aic7xxx/ahc/ahc_eisa/Makefile > ============================================================================== > --- stable/10/sys/modules/aic7xxx/ahc/ahc_eisa/Makefile Thu Aug 21 21:05:58 2014 (r270305) > +++ stable/10/sys/modules/aic7xxx/ahc/ahc_eisa/Makefile Thu Aug 21 21:36:06 2014 (r270306) > @@ -5,7 +5,7 @@ > KMOD= ahc_eisa > > SRCS= ahc_eisa.c > -SRCS+= device_if.h bus_if.h eisa_if.h > +SRCS+= device_if.h bus_if.h eisa_if.h pci_if.h > SRCS+= opt_scsi.h opt_cam.h opt_aic7xxx.h > > CFLAGS+= -I${.CURDIR}/../../../../dev/aic7xxx -I.. > I just discovered I committed this directly to 10-stable. I had intended to commit it to -current and then insta-mfc it (it fixes a problem that is masked on -current by the fact that eisa is disabled by default there). -- Ian