Date: Tue, 14 Sep 2021 14:45:04 +0200 From: Stefan Esser <se@freebsd.org> To: Emmanuel Vadot <manu@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 72629b6891c8 - main - ports-mgmt/pkg-devel: Fix packaging from poudriere Message-ID: <74e99906-996e-0b90-0113-995bc5768341@freebsd.org> In-Reply-To: <YUCVGFqU37heG8SF@FreeBSD.org> References: <202109141152.18EBqJDu036479@gitrepo.freebsd.org> <YUCVGFqU37heG8SF@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------8XAlbDC7jKGW08rBAd8zCqqB
Content-Type: multipart/mixed; boundary="------------dSWpIWy0r4N5lo01CbwzLvIt";
protected-headers="v1"
From: Stefan Esser <se@freebsd.org>
To: Emmanuel Vadot <manu@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,
dev-commits-ports-main@freebsd.org
Message-ID: <74e99906-996e-0b90-0113-995bc5768341@freebsd.org>
Subject: Re: git: 72629b6891c8 - main - ports-mgmt/pkg-devel: Fix packaging
from poudriere
References: <202109141152.18EBqJDu036479@gitrepo.freebsd.org>
<YUCVGFqU37heG8SF@FreeBSD.org>
In-Reply-To: <YUCVGFqU37heG8SF@FreeBSD.org>
--------------dSWpIWy0r4N5lo01CbwzLvIt
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Am 14.09.21 um 14:27 schrieb Alexey Dokuchaev:
> On Tue, Sep 14, 2021 at 11:52:19AM +0000, Emmanuel Vadot wrote:
>> commit 72629b6891c832e57808a0bdb686c2433951c546
>>
>> ports-mgmt/pkg-devel: Fix packaging from poudriere
>> =20
>> If there is no pkg(8) installed in the jail/host pkg-static will b=
e used
>> but we don't have pkg-static with SAN so add a link in the WRKSRC.=
>> Also poudriere just extract pkg-static from the pkg archive so cp
>> instead of symlink
>> ---
>> +.if ${PORT_OPTIONS:MSAN}
>> +post-build:
>> + @(cd ${WRKSRC}/src && \
>> + ${LN} -fs pkg pkg-static)
>> +.endif
>=20
> Why `cd' when `${LN} -fs pkg ${WRKSRC}/src/pkg-static' would suffice?
I wondered about this too, but also about post-install ...
Since source and destination are in the same directory (and thus in the
same file system) a hard link seems to be the best solution, in both case=
s.
I'd have used "${LN} -f ${WRKSRC}/src/pkg ${WRKSRC}/src/pkg-static" in
post-build and the same concept with appropriate paths in post-install
(in post-install instead of the ${CP}).
--------------dSWpIWy0r4N5lo01CbwzLvIt--
--------------8XAlbDC7jKGW08rBAd8zCqqB
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"
-----BEGIN PGP SIGNATURE-----
wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmFAmVEFAwAAAAAACgkQR+u171r99USO
EAgAojyunUBCiHYarQZaFO4tXjOFLU6lMXPFFoIz99VieVFZYVGvyIe7xqRVnsTb2UyyU4mImyay
8XyNStWweqot7TjwsHuu/bAIcsTYddtwKtwy8sPyQAnkpQstk2LU778I5hrWTGJL8YRvx3W62FWi
PzdC14spjJVjC2Mes7lsEfJr9JESTO3O4IjwcdhBcQXVD4AkgkSGT5Yw8pL/mEVVP+K7Xc143Xxd
QzpB5YbZ29rxuqAhSWi+IzQc2t1KtVYiqqF3HQBO/2y6OtlfNjt2bB3U3hsutY7UfxGRnHaHp+BE
32IA9+WNtkPYY/ZOQPHg/8oj+37e+2r3ZePHKaCtmA==
=+9BD
-----END PGP SIGNATURE-----
--------------8XAlbDC7jKGW08rBAd8zCqqB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?74e99906-996e-0b90-0113-995bc5768341>