From owner-svn-src-all@freebsd.org Tue Dec 4 17:35:54 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 62EF61313AD6; Tue, 4 Dec 2018 17:35:54 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B87FE843B0; Tue, 4 Dec 2018 17:35:53 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id wB4HB77W037203; Tue, 4 Dec 2018 09:11:07 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id wB4HB7Fc037202; Tue, 4 Dec 2018 09:11:07 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201812041711.wB4HB7Fc037202@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r341446 - head/release/amd64 In-Reply-To: <05039715-2792-fdb2-735f-c5842f4d8087@FreeBSD.org> To: Yuri Pankov Date: Tue, 4 Dec 2018 09:11:07 -0800 (PST) CC: Alexey Dokuchaev , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: B87FE843B0 X-Spamd-Result: default: False [-0.37 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[rgrimes@freebsd.org]; NEURAL_HAM_MEDIUM(-0.36)[-0.365,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.23)[-0.231,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[dnsmgr.net]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-0.02)[country: US(-0.09)]; MX_GOOD(-0.01)[cached: pdx.rh.CN85.dnsmgr.net]; NEURAL_HAM_SHORT(-0.64)[-0.642,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 17:35:54 -0000 > Alexey Dokuchaev wrote: > > On Mon, Dec 03, 2018 at 10:31:57PM +0000, Yuri Pankov wrote: > >> New Revision: 341446 > >> URL: https://svnweb.freebsd.org/changeset/base/341446 > >> > >> Log: > >> mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs. > >> > >> This fixes 'cdrom' target in the case when world was built by user, > >> and not root. > > > > Could you please explain why -p should not have been used here? I fail > > to understand this from the commit log. I've always considered preserving > > various file metadata as a good thing to do, and this commit puzzles me. > > Because the target is on msdosfs, and the only metadata that can be > preserved is modification time which isn't that useful with the file > being hidden in ESP. OTOH, 'cp -p' fails trying to preserve owner/group > if source is not owned by root (as commit message says). Additional > 'chmod' call done in HBSD doesn't do much as well -- it seems we can > only set/unset owner's 'write' flag which corresponds to DOS 'readonly' > attribute. > I agree with this assesment, and the present state of the script, besides cp followed by chmod is usually spelled ${INSTALL}. -- Rod Grimes rgrimes@freebsd.org