From owner-freebsd-current@FreeBSD.ORG Sat Mar 8 11:48:49 2008 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA1B9106566B for ; Sat, 8 Mar 2008 11:48:49 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (smtp5-g19.free.fr [212.27.42.35]) by mx1.freebsd.org (Postfix) with ESMTP id 973F58FC16 for ; Sat, 8 Mar 2008 11:48:49 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp5-g19.free.fr (Postfix) with ESMTP id 8642D3F6174; Sat, 8 Mar 2008 12:48:48 +0100 (CET) Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98]) by smtp5-g19.free.fr (Postfix) with ESMTP id 779CB3F6194; Sat, 8 Mar 2008 12:48:48 +0100 (CET) Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25]) by tatooine.tataz.chchile.org (Postfix) with ESMTP id 0B1D69BF12; Sat, 8 Mar 2008 11:48:11 +0000 (UTC) Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000) id F2A03405D; Sat, 8 Mar 2008 12:48:10 +0100 (CET) Date: Sat, 8 Mar 2008 12:48:10 +0100 From: Jeremie Le Hen To: Jaakko Heinonen Message-ID: <20080308114810.GE39998@obiwan.tataz.chchile.org> References: <20080304125303.GA2619@ws64.jh.dy.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080304125303.GA2619@ws64.jh.dy.fi> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: freebsd-current@FreeBSD.org, sos@FreeBSD.org Subject: Re: [patch] burncd(8) signal and error handling improvements X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Mar 2008 11:48:50 -0000 Hi Jakko, On Tue, Mar 04, 2008 at 02:53:03PM +0200, Jaakko Heinonen wrote: > burncd(8) doesn't handle signals and interrupting burncd during > operation for example with SIGINT (^C) may leave the drive spinning and > locked. This may happen also if you try to write a too large image to a > disc and burncd(8) exits with an I/O error. > > Attached patch implements signal handling for burncd(8). It does > CDRIOCFLUSH ioctl to attempt leave burner sane state when burning is > interrupted with SIGHUP, SIGINT, SIGTERM or in case an I/O error occurs > during write. Blanking will still continue after interrupt but it seems > to finish correctly even after burncd(8) has quit. > > Relevant PR is bin/48730 which has an older version of the patch. Thank you for the work! This was quite annoying :-). Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org >