From owner-cvs-src@FreeBSD.ORG Fri Mar 16 11:16:13 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 911DF16A403; Fri, 16 Mar 2007 11:16:13 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc3-cdif2-0-0-cust64.cdif.cable.ntl.com [81.106.128.65]) by mx1.freebsd.org (Postfix) with ESMTP id 3D5F213C455; Fri, 16 Mar 2007 11:16:13 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.66 (FreeBSD)) (envelope-from ) id 1HSAPs-000Asv-Bu; Fri, 16 Mar 2007 11:16:12 +0000 Date: Fri, 16 Mar 2007 11:16:12 +0000 From: Ceri Davies To: Pawel Jakub Dawidek Message-ID: <20070316111612.GZ53780@submonkey.net> References: <200703160313.l2G3DTHP048236@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UvwuEPigQXXfOf7G" Content-Disposition: inline In-Reply-To: <200703160313.l2G3DTHP048236@repoman.freebsd.org> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.13 (2006-08-11) Sender: Ceri Davies Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libufs type.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2007 11:16:13 -0000 --UvwuEPigQXXfOf7G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 16, 2007 at 03:13:29AM +0000, Pawel Jakub Dawidek wrote: > pjd 2007-03-16 03:13:29 UTC >=20 > FreeBSD src repository >=20 > Modified files: > lib/libufs type.c=20 > Log: > The ufs_disk_fillout(3) can take special device name (with or without /= dev/ > prefix) as an argument and mount point path. At the end it has to find > device name file system is stored on, which means when mount point path= is > given, it tries to look into /etc/fstab and find special device > corresponding to the given mount point. This is not perfect, because it > doesn't handle the case when file system is mounted by hand and mount p= oint > is given as an argument. > =20 > I found this problem while trying to use snapinfo(8), which passes mount > points to the ufs_disk_fillout(3) function, but I had file system mount= ed > manually, so snapinfo(8) was exiting with the error below: > =20 > ufs_disk_fillout: No such file or directory > =20 > I modified libufs(3) to handle those arguments (the order is important): > =20 > 1. special device with /dev/ prefix > 2. special device without /dev/ prefix > 3. mount point listed in /etc/fstab, directory exists > 4. mount point listed in /etc/fstab, directory doesn't exist > 5. mount point of a file system mounted by hand Is there any chance that this, or the related snapinfo commit, fixes PR 94635? Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --UvwuEPigQXXfOf7G Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFF+nx8ocfcwTS3JF8RAvxwAJ9aASVui65UIpKrg0L9Rp/eVzlkKwCgim6Q eW5zcRL2Yk2R/DNQumNpxzw= =ZRw4 -----END PGP SIGNATURE----- --UvwuEPigQXXfOf7G--