From owner-freebsd-arch Thu Apr 27 10:58:35 2000 Delivered-To: freebsd-arch@freebsd.org Received: from ns1.yes.no (ns1.yes.no [195.204.136.10]) by hub.freebsd.org (Postfix) with ESMTP id B5DBD37BED7 for ; Thu, 27 Apr 2000 10:58:28 -0700 (PDT) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218]) by ns1.yes.no (8.9.3/8.9.3) with ESMTP id TAA01985 for ; Thu, 27 Apr 2000 19:58:24 +0200 (CEST) Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id TAA01293 for freebsd-arch@freebsd.org; Thu, 27 Apr 2000 19:58:23 +0200 (CEST) Received: from bubba.whistle.com (bubba.whistle.com [207.76.205.7]) by hub.freebsd.org (Postfix) with ESMTP id 5B68A37B8BA; Thu, 27 Apr 2000 10:58:01 -0700 (PDT) (envelope-from archie@whistle.com) Received: (from archie@localhost) by bubba.whistle.com (8.9.3/8.9.2) id KAA66218; Thu, 27 Apr 2000 10:58:01 -0700 (PDT) From: Archie Cobbs Message-Id: <200004271758.KAA66218@bubba.whistle.com> Subject: Re: limits.h and styles; ANSIfication In-Reply-To: <20000424125408.A13576@dragon.nuxi.com> from "David O'Brien" at "Apr 24, 2000 12:54:09 pm" To: obrien@freebsd.org Date: Thu, 27 Apr 2000 10:58:01 -0700 (PDT) Cc: green@freebsd.org (Brian Fundakowski Feldman), arch@freebsd.org X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG David O'Brien writes: > > http://people.FreeBSD.org/~green/limits.patch > > Why are you removing the ()'s from the macros? They are there to protect > the expansion and should stay. You don't need paretheses when C cannot possibly parse it any other way.. eg "0xffff" is always the same as "(0xffff)" in C. It seems to me the paretheses were there previously to protect the "-1" part. As for #define QUAD_MIN (LONG_MIN) they're also unnecessary, inductively assuming the #definition of LONG_MIN is itself suitably protected. -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message