From owner-freebsd-current@FreeBSD.ORG Fri May 1 17:34:45 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5054E106566B; Fri, 1 May 2009 17:34:45 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id EFE048FC28; Fri, 1 May 2009 17:34:44 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n41HYhoi019412 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 1 May 2009 10:34:44 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <49FB32B3.1080707@freebsd.org> Date: Fri, 01 May 2009 10:34:43 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.18 (X11/20081209) MIME-Version: 1.0 To: Bruce Simpson References: <49E6DB25.2010601@sippysoft.com> <49E6FF8F.4070403@sippysoft.com> <49ED6AD2.4010006@incunabulum.net> <49EDDD51.9040608@freebsd.org> <49FAF3F5.5070609@incunabulum.net> <49FB1A3F.3000809@freebsd.org> <49FB1BE4.20502@freebsd.org> <49FB288E.7070402@incunabulum.net> In-Reply-To: <49FB288E.7070402@incunabulum.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-CTc-dcc1-Metrics: ebb.errno.com; whitelist Cc: Dennis Melentyev , stable@freebsd.org, "current@freebsd.org" , Maxim Sobolev Subject: Re: kernel compile fails without AH_SUPPORT_AR5416 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 May 2009 17:34:45 -0000 Bruce Simpson wrote: > Sam Leffler wrote: >> ... >>>>> the "ath_hal" device. >>> Do not modify ah_desc.h like you've done. Add this to conf/options >>> >>> ATH_HAL opt_ah.h >>> >>> and use that to enable AH_SUPPORT_AR5416. >>> >> To clarify the first comment: you've made it impossible to build code >> w/o the extended format descriptor; this is what I find unacceptable. > > Ah, of course, duh -- I forgot about the CaPiTalIzAtion of the device > name gets pulled into config(5) with the 'device' keyword. Thanks for > the reminder... > > This is a much cleaner fix for the issue than forcing the option to be > set on always. It looks like HEAD has this issue too and this can go > right in there. > > Are we happy with AH_SUPPORT_AR5416 being enabled in 7.x GENERIC? > The 'out of box' config hasn't been broken by the change and this is > identical to to the situation in HEAD as far as I can see. Not sure I understand your last question. If you fix the code so it's not dependent on "options AH_SUPPORT_AR5416" then you can just remove it from the GENERIC config files. Otherwise the intent was that "device ath_hal" would enable all available chip support so yes we want support for 5416 and later parts. In fact AH_SUPPORT_AR5416 is probably not needed at all; we can conditionalize the code according to the device config; e.g. #if defined(ATH_HAL) || defined(ATH_AR5416) || defined(ATH_AR9160) || defined(ATH_AR9280) or possibly consolidate this check in one spot and define something like AH_SUPPORT_AR5416 to enable the extended descriptor format support. Beware of driver code that depends on AH_SUPPORT_AR5416 (grep shows several uses). For now just fixing the immediate problem is sufficient; I'll get to cleaning this stuff up later (unless you care to deal with it). Sam