From owner-svn-src-head@freebsd.org Thu May 18 02:44:05 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15CC9D72B0E; Thu, 18 May 2017 02:44:05 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-pg0-x22b.google.com (mail-pg0-x22b.google.com [IPv6:2607:f8b0:400e:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D8CFD14F2; Thu, 18 May 2017 02:44:04 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-pg0-x22b.google.com with SMTP id x64so15631470pgd.3; Wed, 17 May 2017 19:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+/l3pdIHfwwJXOcnJDEBCOlhx3RBYfNMazMGdvaxtI0=; b=fD1qkp3qNd70tpMO3AwVazW4ueUfVrLXEONVhZDQMFO0DNHQ+2WQzy6KuTN5q2rpH4 SMngOKQ5cT0FIWU6Zrt0gtKwyQGDkD/4jgIsZ2hbmoDBn1qBCIPaWPP40qmw2RVGXBpA yzbKwRUhJLUcM1ALHPT8sOCxfMlBQVZx07PaPlEMAIbB+XvHs2xKh8OuG76AeCpfxnH0 Tg5AQlAPNXXb30bEp2E6et95NdrHW1TeEQRdF1hb8Wk73SgjW+T++KDcb+MW88gMlgsr /qcXjtaA7/gI8LvgRUs/8T5pncyh8cJuF6Cby3stR92DfkXzvRXhdE1IGvLPILc84Y6L MxqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+/l3pdIHfwwJXOcnJDEBCOlhx3RBYfNMazMGdvaxtI0=; b=s3i/KqfiYphXb1Z6gDKOrHUx+BdJ7T6mKt97VPANKYuE0EiC87v+aOiOEnt0zt+oC5 H/0tf8V9tsbdvTRp/htqvFfzbSbCvWh/r9QBua2hN2nsyVPf5pvOUpi9vXJ7qtmRHvd3 zFLbRHIOsDB/sV82v8rbP8N9DBJGf1icc9PUDwUXTyzOd3BtYAxWWCXdyN4LQILTSrA2 VtjU5vGvnatiL9S+jrYcgt/GUQl3RTGWQbvEE9vD2KE7vcoOPo17faKbjs2wYg6sAUPv fga2YVBIBZpl1KoYOJEvYyw0+VVfkKiLEu7k7xOdUzL7c2hj0Vetij7A4Ww+K4XGj5tq TNFA== X-Gm-Message-State: AODbwcCh1QGfWuOYxtpVksMVrDEFSziMsi5Hd2yQM0Su9Vi6zPo8bZID 1nfiU4MBNQ5u+w2TK5Q= X-Received: by 10.99.55.88 with SMTP id g24mr1898807pgn.176.1495075444245; Wed, 17 May 2017 19:44:04 -0700 (PDT) Received: from spectre.mavhome.dp.ua ([2601:647:4b00:5308:228:f8ff:fe04:d12]) by smtp.gmail.com with ESMTPSA id x12sm6662286pge.60.2017.05.17.19.44.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 May 2017 19:44:02 -0700 (PDT) Sender: Alexander Motin Subject: Re: svn commit: r310230 - head/sys/cam/scsi To: Bryan Drewery , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201612181502.uBIF2o4a023448@repo.freebsd.org> From: Alexander Motin Message-ID: <32cea555-27c9-555e-405b-1303bcd7ae17@FreeBSD.org> Date: Wed, 17 May 2017 19:44:01 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 May 2017 02:44:05 -0000 On 17.05.2017 19:00, Bryan Drewery wrote: > On 12/18/16 7:02 AM, Alexander Motin wrote: >> Author: mav >> Date: Sun Dec 18 15:02:50 2016 >> New Revision: 310230 >> URL: https://svnweb.freebsd.org/changeset/base/310230 >> >> Log: >> Don't treat informational exceptions (warnings and impending failures) >> a.k.a. SCSI SMART events as errors. Log them to console and continue. >> >> MFC after: 2 weeks >> >> Modified: >> head/sys/cam/scsi/scsi_all.c >> >> Modified: head/sys/cam/scsi/scsi_all.c >> ============================================================================== >> --- head/sys/cam/scsi/scsi_all.c Sun Dec 18 14:54:20 2016 (r310229) >> +++ head/sys/cam/scsi/scsi_all.c Sun Dec 18 15:02:50 2016 (r310230) >> @@ -1233,58 +1233,58 @@ static struct asc_table_entry asc_table[ >> { SST(0x0A, 0x00, SS_FATAL | ENOSPC, >> "Error log overflow") }, >> /* DTLPWROMAEBKVF */ >> - { SST(0x0B, 0x00, SS_RDEF, >> + { SST(0x0B, 0x00, SS_NOP | SSQ_PRINT_SENSE, > > After this change (removing SS_RETRY), will a retry still occur on the > changed SENSE exceptions via something else? There will be no retry, since it is no longer considered an error. It is successful command completion status. The command will complete normally after just logging the status for administrative purposes. -- Alexander Motin