From owner-cvs-all Tue Feb 19 13:27:31 2002 Delivered-To: cvs-all@freebsd.org Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by hub.freebsd.org (Postfix) with ESMTP id 5F0FA37B402; Tue, 19 Feb 2002 13:27:19 -0800 (PST) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.9.3/8.9.3) with ESMTP id QAA21890; Tue, 19 Feb 2002 16:27:18 -0500 (EST) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.11.6/8.9.1) id g1JLQma52602; Tue, 19 Feb 2002 16:26:48 -0500 (EST) (envelope-from gallatin@cs.duke.edu) Date: Tue, 19 Feb 2002 16:26:48 -0500 From: Andrew Gallatin To: Max Khon Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c if_arc.h if_arp.h if_ethersubr.c if_fddisubr.c if_iso88025subr.c if_var.h if_vlan.c src/sys/netinet if_ether.c if_ether.h Message-ID: <20020219162648.A52559@grasshopper.cs.duke.edu> References: <200202132138.g1DLcuB88159@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200202132138.g1DLcuB88159@freefall.freebsd.org>; from fjoe@FreeBSD.org on Wed, Feb 13, 2002 at 01:38:56PM -0800 X-Operating-System: FreeBSD 4.4-RELEASE on an i386 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Max Khon [fjoe@FreeBSD.org] wrote: > fjoe 2002/02/13 13:38:56 PST <...> > Log: > MFC: ARP support for variable length link level addresses <...> > 1.18.2.13 +4 -0 src/sys/net/if_var.h The addition of a pointer ( u_int8_t *if_broadcastaddr;) into struct ifnet breaks binary compatability in the 4-stable series for 3rd party network drivers by moving the ac_enaddr[] field down in struct arpcom. Eg, for a binary module compiled on 4.1.1 (which worked fine up to now) I now see this: myri0: flags=843 mtu 9000 inet 192.168.1.4 netmask 0xffffff00 broadcast 192.168.1.255 ether 57:98:00:00:00:00 When I should see this: myri0: flags=843 mtu 9000 inet 192.168.1.4 netmask 0xffffff00 broadcast 192.168.1.255 ether 00:60:dd:7f:57:98 Note the mac address is shifted over by the size of a pointer. I'd greatly appreciate it if you could find somewhere else to put this pointer that does not break binary compatbility. Thanks! Drew (Wearing his Myricom Inc. hat). To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message