From owner-freebsd-hackers@FreeBSD.ORG  Tue Mar 11 21:33:34 2014
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5F027949;
 Tue, 11 Mar 2014 21:33:34 +0000 (UTC)
Received: from mail-ob0-x229.google.com (mail-ob0-x229.google.com
 [IPv6:2607:f8b0:4003:c01::229])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1D360681;
 Tue, 11 Mar 2014 21:33:34 +0000 (UTC)
Received: by mail-ob0-f169.google.com with SMTP id va2so9113816obc.28
 for <multiple recipients>; Tue, 11 Mar 2014 14:33:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=Xi6UI2edV41KTN/ShFQcFdniA4TQvn1LVbEdCEZhUqQ=;
 b=OZtby6TTuTLexmsWUBqMlybLW7O7wzS2tkK76Q0oo8h24crnc+amZttLi5hbQW65ay
 kEqKpepiL1A5JKlIP2Ek8QX8cyhB+EXnE1iX3XKEy9n0heezbsm5xwlqesB7jGAPh4PO
 DmVMLbC51zEPFbqfobeVcVBzMOX3x1rLPFiBzLNJVMp5NPlFW4H2btUchxmyA9xbPAPk
 CZ0mqTDu5aPKSAlqOvntjyYyo6UD6yOrBUd7bi2uu//T1zNPz3ERNhDXOTrktZgElKUo
 Mj1IfhsXz2BmX6llel7mnDyK99Iqie3JvW7kHiLGK6Fv51/Nljnh6IEiDcwLxAUdbQDz
 eZpw==
MIME-Version: 1.0
X-Received: by 10.182.243.138 with SMTP id wy10mr218397obc.83.1394573613469;
 Tue, 11 Mar 2014 14:33:33 -0700 (PDT)
Received: by 10.76.132.8 with HTTP; Tue, 11 Mar 2014 14:33:33 -0700 (PDT)
In-Reply-To: <201403111722.31559.jhb@freebsd.org>
References: <CAFMmRNy9EG3byRV1b=4W5MejMiAz8yV6UnnEMjcJmY-FyMj2sg@mail.gmail.com>
 <201402271330.02699.jhb@freebsd.org>
 <CAFMmRNw-pKOczNyNwi5jhJEKW=sYeGe8DB5URGT=B-Z-prOe0w@mail.gmail.com>
 <201403111722.31559.jhb@freebsd.org>
Date: Tue, 11 Mar 2014 17:33:33 -0400
Message-ID: <CAFMmRNy5QS8oCjeQbjWbvy=Q3DNTqi6bTMWBcyCnULe6DgSV1A@mail.gmail.com>
Subject: Re: [PATCH] Add MSI support to puc(9)
From: Ryan Stone <rysto32@gmail.com>
To: John Baldwin <jhb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org>
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Mar 2014 21:33:34 -0000

On Tue, Mar 11, 2014 at 5:22 PM, John Baldwin <jhb@freebsd.org> wrote:
> This generally looks good, but I don't really like abusing sc_irid as the
> count parameter.  I would use a standalone count and only set sc_irid to 1 if
> it works:
>
>         count = 1;
>         if (pci_alloc_msi(dev, &count) == 0) {
>                 sc->sc_msi = 1;
>                 sc->sc_irid = 1;
>         }

I've updated the patch again.  I should be able to test it on hardware
with MSI support tomorrow morning.