Date: Mon, 01 Dec 2025 15:13:41 +0100 From: Kristof Provost <kp@FreeBSD.org> To: Jessica Clarke <jrtc27@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 5f529f9e292a - main - libc: Fix TESTSDIR for new stdbit tests Message-ID: <F8155CF0-DB70-4CC2-BA60-AA93F47EF8FB@FreeBSD.org> In-Reply-To: <692da1c6.289b3.56e4faf@gitrepo.freebsd.org> References: <692da1c6.289b3.56e4faf@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Thanks! On 1 Dec 2025, at 15:10, Jessica Clarke wrote: > The branch main has been updated by jrtc27: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=5f529f9e292a30c065c316ed5fd0d23e07b26e5c > > commit 5f529f9e292a30c065c316ed5fd0d23e07b26e5c > Author: Jessica Clarke <jrtc27@FreeBSD.org> > AuthorDate: 2025-12-01 14:06:21 +0000 > Commit: Jessica Clarke <jrtc27@FreeBSD.org> > CommitDate: 2025-12-01 14:06:21 +0000 > > libc: Fix TESTSDIR for new stdbit tests > > Otherwise the directory created by etc/mtree/BSD.tests.dist, which > is > where these belong, and referred to by the generated Kyuafile for > /usr/tests/lib/libc (via stdbit's existence in TESTS_SUBDIRS), > ends up > empty with no Kyuafile, which is an error for kyua. > > Reported by: kp > Fixes: 2fb8cbc6ef1b ("libc/tests: add stdbit test > framework and unit tests") > --- > lib/libc/tests/stdbit/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/libc/tests/stdbit/Makefile > b/lib/libc/tests/stdbit/Makefile > index 37450056007a..8dbc86528de3 100644 > --- a/lib/libc/tests/stdbit/Makefile > +++ b/lib/libc/tests/stdbit/Makefile > @@ -1,3 +1,5 @@ > +TESTSDIR= ${TESTSBASE}/lib/libc/stdbit > + > # ensure libc functions are tested, not clang's builtins > CFLAGS+= -fno-builtin [-- Attachment #2 --] <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/xhtml; charset=utf-8"> </head> <body><div style="font-family: sans-serif;"><div class="markdown" style="white-space: normal;"> <p dir="auto">Thanks!</p> <p dir="auto">On 1 Dec 2025, at 15:10, Jessica Clarke wrote:</p> <blockquote style="margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #136BCE; color: #136BCE;"> <p dir="auto">The branch main has been updated by jrtc27:</p> <p dir="auto">URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=5f529f9e292a30c065c316ed5fd0d23e07b26e5c">https://cgit.FreeBSD.org/src/commit/?id=5f529f9e292a30c065c316ed5fd0d23e07b26e5c</a></p>; <p dir="auto">commit 5f529f9e292a30c065c316ed5fd0d23e07b26e5c<br> Author: Jessica Clarke <a href="mailto:jrtc27@FreeBSD.org">jrtc27@FreeBSD.org</a><br> AuthorDate: 2025-12-01 14:06:21 +0000<br> Commit: Jessica Clarke <a href="mailto:jrtc27@FreeBSD.org">jrtc27@FreeBSD.org</a><br> CommitDate: 2025-12-01 14:06:21 +0000</p> <pre style="margin-left: 15px; margin-right: 15px; padding: 5px; border: thin solid gray; overflow-x: auto; max-width: 90vw; background-color: #E4E4E4;"><code style="padding: 0 0.25em; background-color: #E4E4E4;">libc: Fix TESTSDIR for new stdbit tests Otherwise the directory created by etc/mtree/BSD.tests.dist, which is where these belong, and referred to by the generated Kyuafile for /usr/tests/lib/libc (via stdbit's existence in TESTS_SUBDIRS), ends up empty with no Kyuafile, which is an error for kyua. Reported by: kp Fixes: 2fb8cbc6ef1b ("libc/tests: add stdbit test framework and unit tests") </code></pre> <hr> <p dir="auto">lib/libc/tests/stdbit/Makefile | 2 ++<br> 1 file changed, 2 insertions(+)</p> <p dir="auto">diff --git a/lib/libc/tests/stdbit/Makefile b/lib/libc/tests/stdbit/Makefile<br> index 37450056007a..8dbc86528de3 100644<br> --- a/lib/libc/tests/stdbit/Makefile<br> +++ b/lib/libc/tests/stdbit/Makefile<br> @@ -1,3 +1,5 @@<br> +TESTSDIR= ${TESTSBASE}/lib/libc/stdbit<br> +</p> <h2>ensure libc functions are tested, not clang's builtins</h2> <p dir="auto">CFLAGS+= -fno-builtin</p> </blockquote> </div> </div> </body> </html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F8155CF0-DB70-4CC2-BA60-AA93F47EF8FB>