From owner-freebsd-testing@FreeBSD.ORG Wed Apr 30 17:16:11 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 207684D4; Wed, 30 Apr 2014 17:16:11 +0000 (UTC) Received: from mail-vc0-x22e.google.com (mail-vc0-x22e.google.com [IPv6:2607:f8b0:400c:c03::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AE9F81AEE; Wed, 30 Apr 2014 17:16:10 +0000 (UTC) Received: by mail-vc0-f174.google.com with SMTP id ib6so2580262vcb.19 for ; Wed, 30 Apr 2014 10:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=aN0iSWboJq87e9CYZ/R5T4GPlvREqyRaQJ0IB6z7RaY=; b=EQBhpXckoW6UBbuUUsULh8QSx3IPGzrg+1ohnEHCPqEMoQHLejZgGceCrgO/PAe4QN 8HbTIN3tZujuWF1XF65P/VM/Q6WJRCVLVhV4aBkdS/s9CPPtUvqyRnjz4biZzn42MW99 IPnwLswo9uEfEaNgyLuQOMRvwdmG+5KjDsPIeUewk5sUTR232oT/3msSZehph/NBiUh+ TusoYhWAbTZ4itDXkkFDUEOgJgYtDMsXiLhYSgEQygOJU3VNUQl/n825ksTeeKSsm7Yk DhuA11dZHlrLJeY1r8jfHfigttE7LRm9Ub4+4xp5DW3jXBdk7SJAwE7VCU8N5bX7coiv 5hrg== MIME-Version: 1.0 X-Received: by 10.58.219.233 with SMTP id pr9mr4811658vec.10.1398878169164; Wed, 30 Apr 2014 10:16:09 -0700 (PDT) Received: by 10.221.67.136 with HTTP; Wed, 30 Apr 2014 10:16:09 -0700 (PDT) In-Reply-To: <16437CC5729B5345AF77F816513376E820BAFE8E@MX103CL02.corp.emc.com> References: <16437CC5729B5345AF77F816513376E820BAF854@MX103CL02.corp.emc.com> <5F1D5D49-5F39-4EAC-89D5-E4D10FB3B01E@freebsd.org> <16437CC5729B5345AF77F816513376E820BAFE8E@MX103CL02.corp.emc.com> Date: Wed, 30 Apr 2014 10:16:09 -0700 Message-ID: Subject: Re: Please provide process for small, targeted fixes in tools/regression From: Garrett Cooper To: "Peel, Casey" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-testing@freebsd.org" , "bdrewery@FreeBSD.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Apr 2014 17:16:11 -0000 On Fri, Apr 11, 2014 at 6:59 PM, Peel, Casey wrote: > Exellent, thanks Julio. > > Attached are 3 self-contained diffs, one per directory. Descriptions of t= he changes: > * flock - .c changes to fix compiler errors; .t to wrap flock binary for = integrating with prove > * geom_mirror - gmirror won't let you remove the last partition in a mirr= or which all of these testcases do and thus fail (note that I've got these = testcases plus other gmirror testcases already moved over to ATF and going = through internal code reviews now, so maybe we just want to discard this) > * kqueue - kqtest outputs files in TAP-consumable format, this is a .t fi= le to run it through prove > > These were an intial salvo at getting existing tests working for our inte= rnal regression. I'm sure we'll be looking at others as well. If someone ca= n just review the changes, I can get someone internally to commit them if n= ecssary (although these will take more time to review than commit given how= small they are). The test drivers seem ok for TAP, but out of curiosity why are you removing the geom remove testing in the geom_mirror testcases? Does the test not work out of the box on vanilla FreeBSD? Thanks! -Garrett