From owner-svn-src-head@freebsd.org  Thu Sep 17 09:07:46 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 681FA9CD47D;
 Thu, 17 Sep 2015 09:07:46 +0000 (UTC)
 (envelope-from theraven@FreeBSD.org)
Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cloud.theravensnest.org",
 Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2F83B1B2E;
 Thu, 17 Sep 2015 09:07:45 +0000 (UTC)
 (envelope-from theraven@FreeBSD.org)
Received: from [192.168.0.7] (cpc16-cmbg15-2-0-cust60.5-4.cable.virginm.net
 [86.5.162.61]) (authenticated bits=0)
 by theravensnest.org (8.15.2/8.15.2) with ESMTPSA id t8H97f0v049069
 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO);
 Thu, 17 Sep 2015 09:07:42 GMT (envelope-from theraven@FreeBSD.org)
X-Authentication-Warning: theravensnest.org: Host
 cpc16-cmbg15-2-0-cust60.5-4.cable.virginm.net [86.5.162.61] claimed to be
 [192.168.0.7]
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\))
Subject: Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys
From: David Chisnall <theraven@FreeBSD.org>
In-Reply-To: <55FA69BD.10507@selasky.org>
Date: Thu, 17 Sep 2015 10:07:35 +0100
Cc: Gleb Smirnoff <glebius@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <0952027A-5276-487D-99B8-74747B0EEF5D@FreeBSD.org>
References: <201509141052.t8EAqRWf008293@repo.freebsd.org>
 <20150916220559.GS1023@FreeBSD.org> <55FA69BD.10507@selasky.org>
To: Hans Petter Selasky <hps@selasky.org>
X-Mailer: Apple Mail (2.2102)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Sep 2015 09:07:46 -0000

On 17 Sep 2015, at 08:20, Hans Petter Selasky <hps@selasky.org> wrote:
>=20
> On 09/17/15 00:05, Gleb Smirnoff wrote:
>> Weren't you explicitly asked not to touch this system without a =
proper
>> review and discussion?
>=20
> Adding a new function is not touching code.

Adding a new interface to an existing core subsystem is most definitely =
touching the system.  I would expect *anyone* making a change like this =
to have both the design and code reviewed for sanity checking.  For =
someone who has already been required to have explicit review of any =
changes to the subsystem to skip this step shows a flagrant disregard =
for the project=92s policies and best practices.

David