From owner-svn-ports-all@freebsd.org Tue Dec 26 10:53:15 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 73E24E85089; Tue, 26 Dec 2017 10:53:15 +0000 (UTC) (envelope-from rakuco@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 216F96F99A; Tue, 26 Dec 2017 10:53:15 +0000 (UTC) (envelope-from rakuco@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id vBQArEto033735; Tue, 26 Dec 2017 10:53:14 GMT (envelope-from rakuco@FreeBSD.org) Received: (from rakuco@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id vBQArEPg033733; Tue, 26 Dec 2017 10:53:14 GMT (envelope-from rakuco@FreeBSD.org) Message-Id: <201712261053.vBQArEPg033733@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: rakuco set sender to rakuco@FreeBSD.org using -f From: Raphael Kubo da Costa Date: Tue, 26 Dec 2017 10:53:14 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r457276 - in head/devel/qt5-assistant: . files X-SVN-Group: ports-head X-SVN-Commit-Author: rakuco X-SVN-Commit-Paths: in head/devel/qt5-assistant: . files X-SVN-Commit-Revision: 457276 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Dec 2017 10:53:15 -0000 Author: rakuco Date: Tue Dec 26 10:53:13 2017 New Revision: 457276 URL: https://svnweb.freebsd.org/changeset/ports/457276 Log: Drop dependency on www/qt5-webkit. Reduce qt5-assistant's dependency tree by dropping the dependency on QtWebKit. Instead, use qt5-widgets' QTextBrowser to render documentation. An added bonus is that with this change www/qt5-webengine no longer depends on www/qt5-webkit. Page rendering is slightly worse, but everything is still very much readable. Reviewed by: tcberner Differential Revision: https://reviews.freebsd.org/D13630 Added: head/devel/qt5-assistant/files/patch-src_assistant_assistant_assistant.pro (contents, props changed) Modified: head/devel/qt5-assistant/Makefile Modified: head/devel/qt5-assistant/Makefile ============================================================================== --- head/devel/qt5-assistant/Makefile Tue Dec 26 10:50:37 2017 (r457275) +++ head/devel/qt5-assistant/Makefile Tue Dec 26 10:53:13 2017 (r457276) @@ -2,13 +2,14 @@ PORTNAME= assistant DISTVERSION= ${QT5_VERSION} +PORTREVISION= 1 CATEGORIES= devel PKGNAMEPREFIX= qt5- MAINTAINER= kde@FreeBSD.org COMMENT= Qt 5 documentation browser -USE_QT5= core gui help network printsupport sql webkit widgets \ +USE_QT5= core gui help network printsupport sql widgets \ buildtools_build sql-sqlite3_run QT_DIST= tools USES= qmake Added: head/devel/qt5-assistant/files/patch-src_assistant_assistant_assistant.pro ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/devel/qt5-assistant/files/patch-src_assistant_assistant_assistant.pro Tue Dec 26 10:53:13 2017 (r457276) @@ -0,0 +1,13 @@ +Do not use QtWebKit even if it is present to reduce the port's dependencies. +--- src/assistant/assistant/assistant.pro ++++ src/assistant/assistant/assistant.pro +@@ -1,8 +1,4 @@ +-qtHaveModule(webkitwidgets):!contains(QT_CONFIG, static) { +- BROWSER = qtwebkit +-} else { +- BROWSER = qtextbrowser +-} ++BROWSER = qtextbrowser + + QT += widgets network help sql help + qtHaveModule(printsupport): QT += printsupport