From owner-svn-src-head@FreeBSD.ORG Fri Nov 21 09:01:42 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 53040106564A; Fri, 21 Nov 2008 09:01:42 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 10B738FC13; Fri, 21 Nov 2008 09:01:42 +0000 (UTC) (envelope-from des@des.no) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id 2A47A6D43F; Fri, 21 Nov 2008 09:01:41 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id 12F5084460; Fri, 21 Nov 2008 10:01:41 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Joseph Koshy References: <200811151111.mAFBBWnf019276@svn.freebsd.org> Date: Fri, 21 Nov 2008 10:01:41 +0100 In-Reply-To: <200811151111.mAFBBWnf019276@svn.freebsd.org> (Joseph Koshy's message of "Sat, 15 Nov 2008 11:11:32 +0000 (UTC)") Message-ID: <863ahlpi4q.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184994 - head/sys/dev/hwpmc X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Nov 2008 09:01:42 -0000 Joseph Koshy writes: > Modified: head/sys/dev/hwpmc/hwpmc_mod.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/hwpmc/hwpmc_mod.c Sat Nov 15 11:07:54 2008 (r184993) > +++ head/sys/dev/hwpmc/hwpmc_mod.c Sat Nov 15 11:11:32 2008 (r184994) > @@ -4656,6 +4656,9 @@ pmc_cleanup(void) > if (md->pmd_pcpu_fini) > md->pmd_pcpu_fini(cpu); > } > + > + pmc_md_finalize(md); > + > free(md, M_PMC); > md =3D NULL; > pmc_restore_cpu_binding(&pb); This breaks the ia64, powerpc and sparc64 builds; pmc_md_finalize() is only defined for i386 and amd64. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no