Date: Mon, 02 Dec 2013 11:08:08 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com>, Mathieu Arnold <mat@FreeBSD.org>, Kozlov Sergey <kozlov.sergey.404@gmail.com>, Greg Larkin <glarkin@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r335189 - in head/print/pdftk: . files Message-ID: <C89CD972357B819FE03015D6@atuin.in.mat.cc> In-Reply-To: <alpine.LNX.2.00.1312012257230.2185@tuna.site> References: <201311291548.rATFm8g7098382@svn.freebsd.org> <alpine.LNX.2.00.1312012257230.2185@tuna.site>
next in thread | previous in thread | raw e-mail | index | archive | help
+--On 1 d=C3=A9cembre 2013 23:21:51 +0100 Gerald Pfeifer =
<gerald@pfeifer.com>
wrote:
| On Fri, 29 Nov 2013, Mathieu Arnold wrote:
|> Log:
|> Updated port to pdftk-2.02
| :
|> - Added LIB_DEPENDS. Libraries provided by gcc required to run the
|> binary, but gcc is registered only as build dependency. Removing the
|> gcc after installation of pdftk is permitted but breaks pdftk
|=20
| This looks quite dubious since USE_GCC already takes care of=20
| registering this run-time dependency.
|=20
| USE_GCC also takes care of the BUILD_DEPENDency, so the pre-existing
| entry there also is unnecessary.
Hum, does GCC always come with gcj ? I thought it did not, that's why there
was an explicit dependency on it.
|> maintainer timeout.
|=20
| This reminds me, I had submitted another patch in August 2012 (per
| mail, not PR). The -Wl,-path magic is not necessary and manually
| constructing the path to the GCC run-time libraries is A Bad Idea[TM].
| This is what ${LDFLAGS} is there for, and what the second, and more
| important hunk, in my patch below does.
|=20
| Can you guys please give the patch below a spin and review?
The patch looks ok to me, but I don't know a lot about how all that dark
magic works :-p
--=20
Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C89CD972357B819FE03015D6>