From owner-freebsd-current@FreeBSD.ORG Sat Sep 21 00:43:14 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 54EE595D for ; Sat, 21 Sep 2013 00:43:14 +0000 (UTC) (envelope-from gibbs@freebsd.org) Received: from aslan.scsiguy.com (aslan.scsiguy.com [70.89.174.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 06F862CAB for ; Sat, 21 Sep 2013 00:43:13 +0000 (UTC) Received: from scottherod-vm.sldomain.com (207-225-98-3.dia.static.qwest.net [207.225.98.3]) (authenticated bits=0) by aslan.scsiguy.com (8.14.7/8.14.5) with ESMTP id r8L0hBtT062758 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 20 Sep 2013 18:43:12 -0600 (MDT) (envelope-from gibbs@freebsd.org) Subject: Re: ZFS secondarycache on SSD problem on r255173 Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Content-Type: text/plain; charset=us-ascii From: "Justin T. Gibbs" X-Priority: 3 In-Reply-To: <4AA28730F331444AB13108ABF0CD68B7@multiplay.co.uk> Date: Fri, 20 Sep 2013 18:43:09 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <1379069539.824504225.3b9xwugp@fmst-6.ukr.net><74C1D072-77BB-4D6C-B78F-C8D2731FA0CF@sarenet.es><1379333192.127359970.ma5jnbc5@fmst-6.ukr.net> <1379334340.567465877.0b1lli6r@fmst-6.ukr.net> <8365CE736DC749DF95D0030A725211F6@multiplay.co.uk> <02549AD9-C456-4E17-927C-B4BCC97F8CC8@freebsd.org> <4AA28730F331444AB13108ABF0CD68B7@multiplay.co.uk> To: Steven Hartland X-Mailer: Apple Mail (2.1510) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (aslan.scsiguy.com [70.89.174.89]); Fri, 20 Sep 2013 18:43:13 -0600 (MDT) Cc: freebsd-current@freebsd.org, Borja Marcos , Dmitriy Makarov X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Sep 2013 00:43:14 -0000 On Sep 17, 2013, at 4:53 PM, Steven Hartland = wrote: > ----- Original Message ----- From: "Justin T. Gibbs" = >=20 >=20 >> Sorry for being slow to chime in on this thread. I live in Boulder, = CO and we've had a bit of rain. :-) >=20 > Hope all is well your side, everyone safe and sound if may be little = wetter than usual. I have been very fortunate. >> As Steven pointed out, the warning is benign, but does show that the = code I committed to >> -current is not optimizing the allocation size for L2ARC devices. = The fix for this is to find >> the best place during pool creation/load/import to call = vdev_ashift_optimize() on L2ARC >> devices. I will look into this tomorrow, but feel free to suggest a = good spot if you look at it >> before I can. >=20 > The attached patch fixes this for me, not sure if its ideal place for = it and consideration may be > needed in combination with persistent l2arc. Persistent l2arc will require storing and checking the ashift recorded = in the label so bugs and or quirk table changes don't confuse the system. But for now, with no = persistent l2arc support in the tree, I think your placement is fine. I've submitted a request = to RE so I can put your fix into head. -- Justin=