From owner-cvs-all Thu Oct 5 10:29:38 2000 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 655CF37B502; Thu, 5 Oct 2000 10:29:28 -0700 (PDT) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.0/8.11.0) id e95HTOj64305; Thu, 5 Oct 2000 20:29:24 +0300 (EEST) (envelope-from ru) Date: Thu, 5 Oct 2000 20:29:24 +0300 From: Ruslan Ermilov To: Bill Fumerola Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ipfw ipfw.c src/sys/netinet ip_fw.c ip_fw.h Message-ID: <20001005202924.A63643@sunbay.com> Mail-Followup-To: Bill Fumerola , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200010020303.UAA99196@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200010020303.UAA99196@freefall.freebsd.org>; from billf@FreeBSD.org on Sun, Oct 01, 2000 at 08:03:31PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, Oct 01, 2000 at 08:03:31PM -0700, Bill Fumerola wrote: > billf 2000/10/01 20:03:31 PDT > > Modified files: > sbin/ipfw ipfw.c > sys/netinet ip_fw.c ip_fw.h > Log: > Add new fields for more granularity: > IP: version, tos, ttl, len, id > TCP: seq#, ack#, window size > What is the purpose of having the following modifiers? - ipversion (ipfw will only be passed IPv4 packets) - ipid - tcpseq - tcpack How these can be really useful? I think they should be dropped. The current implementation of iplen, ipttl and tcpwin modifiers does not seem interesting, because comparison is only limited to equality. I think they should be modified to accept the range of values, specified by lowest and highest boundaries, so one could specify `iplen 20-50' (20 <= iplen <= 50), `ipttl 0-5' (ipttl <= 5), etc. Bill, I have finished updating the manual, but do not want to commit the change before you answer my questions above. -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message