From owner-cvs-all Tue Jul 30 7:31:13 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B2AAB37B400; Tue, 30 Jul 2002 07:31:07 -0700 (PDT) Received: from silver.carrots.uucp.r.dl.itc.u-tokyo.ac.jp (IP1A0644.kng.mesh.ad.jp [211.13.34.138]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD41043E31; Tue, 30 Jul 2002 07:30:59 -0700 (PDT) (envelope-from tanimura@r.dl.itc.u-tokyo.ac.jp) Received: from silver.carrots.uucp.r.dl.itc.u-tokyo.ac.jp (localhost [127.0.0.1]) by silver.carrots.uucp.r.dl.itc.u-tokyo.ac.jp (8.12.5/3.7W-carrots-Keikyu-Kurihama) with ESMTP id g6UETF0k040381 ; Tue, 30 Jul 2002 23:30:16 +0900 (JST) Message-Id: <200207301430.g6UETF0k040381@silver.carrots.uucp.r.dl.itc.u-tokyo.ac.jp> Date: Tue, 30 Jul 2002 23:29:15 +0900 From: Seigo Tanimura To: John Baldwin Cc: Julian Elischer , Seigo Tanimura , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_condvar.c kern_synch.c In-Reply-To: References: <200207301012.g6UACCNY037208@freefall.freebsd.org> User-Agent: Wanderlust/2.8.1 (Something) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (=?ISO-8859-1?Q?Unebigory=F2mae?=) APEL/10.3 MULE XEmacs/21.1 (patch 14) (Cuyahoga Valley) (i386--freebsd) Organization: Digital Library Research Division, Information Techinology Centre, The University of Tokyo MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG [Added Julian Elischer, the KSEmeister] On Tue, 30 Jul 2002 09:28:18 -0400 (EDT), John Baldwin said: John> On 30-Jul-2002 Seigo Tanimura wrote: >> tanimura 2002/07/30 03:12:11 PDT >> >> Modified files: >> sys/kern kern_condvar.c kern_synch.c >> Log: >> In endtsleep() and cv_timedwait_end(), a thread marked TDF_TIMEOUT may >> be swapped out. Do not put such the thread directly back to the run >> queue. John> Umm, we don't swap out runnable threads do we? I thought we only swapped John> out sleeping threads. Oh, the state is incorrectly set to TDS_SLP in the We used to do so, until KSE milestone 3. Please refer to sys/vm/vm_glue.c rev 1.138. Julian, are we going to swap out a runnable thread, or do we just leave it as we used to do? John> code. *sigh* That is grossly wrong because the thread isn't on a sleep John> queue. TDS_UNQUEUED sounds more suitable. -- Seigo Tanimura To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message