From owner-svn-src-all@FreeBSD.ORG  Fri Dec 30 02:54:57 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1E91F106566B;
	Fri, 30 Dec 2011 02:54:57 +0000 (UTC) (envelope-from scf@FreeBSD.org)
Received: from mail.farley.org (mail.farley.org
	[IPv6:2001:470:1f07:14d3:2::11])
	by mx1.freebsd.org (Postfix) with ESMTP id C707D8FC13;
	Fri, 30 Dec 2011 02:54:56 +0000 (UTC)
Received: from thor.farley.org (HPooka@thor.farley.org
	[IPv6:2001:470:1f07:14d3:1::5])
	by mail.farley.org (8.14.5/8.14.5) with ESMTP id pBU2st8u028658;
	Thu, 29 Dec 2011 21:54:55 -0500 (EST) (envelope-from scf@FreeBSD.org)
Date: Thu, 29 Dec 2011 21:54:55 -0500 (EST)
From: "Sean C. Farley" <scf@FreeBSD.org>
To: Ed Schouten <ed@FreeBSD.org>
In-Reply-To: <201112252015.pBPKFfZ1073959@svn.freebsd.org>
Message-ID: <alpine.BSF.2.02.1112291617110.4588@thor.farley.org>
References: <201112252015.pBPKFfZ1073959@svn.freebsd.org>
User-Agent: Alpine 2.02 (BSF 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
X-Spam-Status: No, score=-1.5 required=4.0 tests=AWL,BAYES_00,SPF_SOFTFAIL
	autolearn=no version=3.3.2
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mail.farley.org
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r228878 - head/include
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Dec 2011 02:54:57 -0000

On Sun, 25 Dec 2011, Ed Schouten wrote:

> Author: ed
> Date: Sun Dec 25 20:15:41 2011
> New Revision: 228878
> URL: http://svn.freebsd.org/changeset/base/228878
>
> Log:
>  Remove unneeded guard.
>
>  There is no reason why <stdbool.h> needs an include guard. It is already
>  protected by __bool_true_false_are_defined.
>
> Modified:
>  head/include/stdbool.h
>
> Modified: head/include/stdbool.h
> ==============================================================================
> --- head/include/stdbool.h	Sun Dec 25 18:15:31 2011	(r228877)
> +++ head/include/stdbool.h	Sun Dec 25 20:15:41 2011	(r228878)
> @@ -26,9 +26,6 @@
>  * $FreeBSD$
>  */
>
> -#ifndef _STDBOOL_H_
> -#define	_STDBOOL_H_
> -
> #ifndef __bool_true_false_are_defined
> #define	__bool_true_false_are_defined	1
>
> @@ -44,5 +41,3 @@ typedef	int	_Bool;
>
> #endif /* !__cplusplus */
> #endif /* __bool_true_false_are_defined */
> -
> -#endif /* !_STDBOOL_H_ */

I just thought of this while reviewing the change:  should 
__bool_true_false_are_defined be set only if __cplusplus is not set?  It 
should be set for C99, but I wonder if it should be set for C++.

Also, is there a style requirement that the guard for a header file be 
based off of the name of the file?  I did not see anything obvious for 
this within style(9), but I am curious.

Sean
-- 
scf@FreeBSD.org