From owner-freebsd-hackers Sun Jan 18 06:52:12 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id GAA11848 for hackers-outgoing; Sun, 18 Jan 1998 06:52:12 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from parkplace.cet.co.jp (parkplace.cet.co.jp [202.32.64.1]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA11803 for ; Sun, 18 Jan 1998 06:51:59 -0800 (PST) (envelope-from michaelh@cet.co.jp) Received: from localhost (michaelh@localhost) by parkplace.cet.co.jp (8.8.8/CET-v2.2) with SMTP id IAA14255; Sun, 18 Jan 1998 08:06:18 GMT Date: Sun, 18 Jan 1998 17:06:18 +0900 (JST) From: Michael Hancock To: Brandon Gillespie cc: hackers@FreeBSD.ORG Subject: Re: /usr/include/sys/types.h FD_ZERO/FD_COPY macros In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk It really doesn't matter since they're hidden behind the macro anyway. BTW, have you looked at the source for bc On Thu, 15 Jan 1998, Brandon Gillespie wrote: > The macro's use bzero/bcopy... currently: > > #define FD_COPY(f, t) bcopy(f, t, sizeof(*(f))) > #define FD_ZERO(p) bzero(p, sizeof(*(p))) > > Should probably be (in order to be more standard): > > #define FD_COPY(f, t) memcpy(t, f, sizeof(*(f))) > #define FD_ZERO(p) memset(p, 0, sizeof(*(p))) > > Unless I'm mistaken? (for more info on the FD_* look at 'man select') > > -Brandon Gillespie > -- michaelh@cet.co.jp http://www.cet.co.jp CET Inc., Daiichi Kasuya BLDG 8F 2-5-12, Higashi Shinbashi, Minato-ku, Tokyo 105 Japan Tel: +81-3-3437-1761 Fax: +81-3-3437-1766