From owner-freebsd-emulation@FreeBSD.ORG  Mon Jul 28 10:28:43 2008
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: freebsd-emulation@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CDE93106568A
	for <freebsd-emulation@freebsd.org>;
	Mon, 28 Jul 2008 10:28:43 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247])
	by mx1.freebsd.org (Postfix) with ESMTP id 7EAD38FC0C
	for <freebsd-emulation@freebsd.org>;
	Mon, 28 Jul 2008 10:28:43 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 4739967ECCB;
	Mon, 28 Jul 2008 12:27:28 +0200 (CEST)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id mw4kolSRYeq5; Mon, 28 Jul 2008 12:27:19 +0200 (CEST)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 5E3756733CA;
	Mon, 28 Jul 2008 12:27:18 +0200 (CEST)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.14.2/8.14.2/Submit) id m6SARGwJ079364;
	Mon, 28 Jul 2008 12:27:16 +0200 (CEST) (envelope-from rdivacky)
Date: Mon, 28 Jul 2008 12:27:15 +0200
From: Roman Divacky <rdivacky@freebsd.org>
To: Chagin Dmitry <chagin.dmitry@gmail.com>
Message-ID: <20080728102715.GA78842@freebsd.org>
References: <200807250700.m6P70FSF036132@freefall.freebsd.org>
	<20080726091045.4c617dc7@deskjail>
	<alpine.BSF.1.10.0807271958020.3912@ora.chd.net>
	<20080728085403.58063b2gbchdjtic@webmail.leidinger.net>
	<alpine.BSF.1.10.0807281300060.1453@ora.chd.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.BSF.1.10.0807281300060.1453@ora.chd.net>
User-Agent: Mutt/1.4.2.3i
Cc: Alexander Leidinger <Alexander@leidinger.net>,
	freebsd-emulation@freebsd.org
Subject: Re: kern/117010: [linux] linux_getdents() get somethinng like
	buffer overflow
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jul 2008 10:28:43 -0000


[snip of technical discussion]

while I agree with the attitude that it should be fixed properly, we are
in a situation where a simple patch fixes a problem. and the fix is correct.

I think we should just commit Dmitry's patch and then talk about how to change
linux_getdents() further. I looked at the Linux code and the alignment is really
+2 for 32bit and +1 for 64 bit as Dmitry's patch does.

do you guys agree that fixing the problem the simplest/fastest way now and then
changing other things is the correct way?

roman