From owner-p4-projects Fri May 31 11: 7:55 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id D0D1D37B400; Fri, 31 May 2002 11:07:25 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from srv1.cosmo-project.de (srv1.cosmo-project.de [213.83.6.106]) by hub.freebsd.org (Postfix) with ESMTP id 85CB937B410; Fri, 31 May 2002 11:07:18 -0700 (PDT) Received: from cicely5.cicely.de (cicely5.cicely.de [IPv6:3ffe:400:8d0:301:200:92ff:fe9b:20e7]) (authenticated bits=0) by srv1.cosmo-project.de (8.12.3/8.12.3) with ESMTP id g4VI7CHc056484 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Fri, 31 May 2002 20:07:13 +0200 (CEST) (envelope-from ticso@cicely5.cicely.de) Received: from cicely5.cicely.de (localhost [IPv6:::1]) by cicely5.cicely.de (8.12.1/8.12.1) with ESMTP id g4VI7GSA016609 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Fri, 31 May 2002 20:07:17 +0200 (CEST)?g (envelope-from ticso@cicely5.cicely.de) Received: (from ticso@localhost) by cicely5.cicely.de (8.12.1/8.12.1/Submit) id g4VI7Gqe016608; Fri, 31 May 2002 20:07:16 +0200 (CEST)?g (envelope-from ticso) Date: Fri, 31 May 2002 20:07:16 +0200 From: Bernd Walter To: Julian Elischer Cc: ticso@cicely.de, Julian Elischer , Perforce Change Reviews Subject: Re: PERFORCE change 12204 for review Message-ID: <20020531180715.GB16281@cicely5.cicely.de> Reply-To: ticso@cicely.de References: <20020531174748.GA16281@cicely5.cicely.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.26i X-Operating-System: FreeBSD cicely5.cicely.de 5.0-CURRENT i386 Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, May 31, 2002 at 10:54:14AM -0700, Julian Elischer wrote: > no that cast is to unsigned int as that is what suword() takes > as an argument.. It takes an unsigned long and will spite a compile time warning on alpha because of casting the 64 bit pointer td->td_mailbox into a 32 bit value. > I would rather have a sptr() and fptr() set that is guaranteed to be > correct. > > comments from others? > > > On Fri, 31 May 2002, Bernd Walter wrote: > > > On Fri, May 31, 2002 at 10:23:22AM -0700, Julian Elischer wrote: > > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=12204 > > > > > > Change 12204 by julian@julian_ref on 2002/05/31 10:22:47 > > > > > > Change type of a pointer variable > > > > > > Affected files ... > > > > > > ... //depot/projects/kse/sys/kern/kern_thread.c#52 edit > > > > > > Differences ... > > > > > > ==== //depot/projects/kse/sys/kern/kern_thread.c#52 (text+ko) ==== > > > > > > @@ -251,7 +251,7 @@ > > > thread_export_context(struct thread *td) > > > { > > > struct kse *ke; > > > - uint td2_mbx; /* XXXKSE */ > > > + uintptr_t td2_mbx; > > > void *addr1; > > > void *addr2; > > > int error; > > > > Don't forget the (uint) cast later in the same function. -- B.Walter COSMO-Project http://www.cosmo-project.de ticso@cicely.de Usergroup info@cosmo-project.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message