From owner-cvs-src@FreeBSD.ORG Fri Mar 5 07:47:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0C7E16A4CE; Fri, 5 Mar 2004 07:47:24 -0800 (PST) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3839843D2F; Fri, 5 Mar 2004 07:47:22 -0800 (PST) (envelope-from ru@ip.net.ua) Received: from heffalump.office.ipnet (heffalump.ip.net.ua [82.193.96.213] (may be forged)) by tigra.ip.net.ua (8.12.10/8.12.9) with ESMTP id i25FoMu8062546 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 5 Mar 2004 17:50:24 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.office.ipnet (8.12.11/8.12.11) id i25FlEJ8051397; Fri, 5 Mar 2004 17:47:14 +0200 (EET) (envelope-from ru) Date: Fri, 5 Mar 2004 17:47:14 +0200 From: Ruslan Ermilov To: Andrey Chernov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG, "David O'Brien" Message-ID: <20040305154714.GA31834@ip.net.ua> References: <200403050147.i251l39I006593@repoman.freebsd.org> <200403042036.i24KaIeq025097@repoman.freebsd.org> <20040305141012.GA10639@ip.net.ua> <20040305143708.GA70192@nagual.pp.ru> <20040305152247.GB11063@ip.net.ua> <20040305152917.GA71254@nagual.pp.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU" Content-Disposition: inline In-Reply-To: <20040305152917.GA71254@nagual.pp.ru> User-Agent: Mutt/1.5.6i X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) Subject: Re: cvs commit: src/gnu/usr.bin/binutils Makefile.inc0 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2004 15:47:25 -0000 --azLHFNyN32YCQGCU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 05, 2004 at 06:29:18PM +0300, Andrey Chernov wrote: > On Fri, Mar 05, 2004 at 05:22:47PM +0200, Ruslan Ermilov wrote: > > > > But it's added last, by the special version of from > > src/tools/build/mk/. >=20 > Why? This way you can't be sure some progam's -I will damage things. > Just add it first instead. >=20 Because what makefiles specifies explicitly (like after your change does for -I/usr/include in the case where cross-tools are built) should be preferred. (Consider an unlikely but still possible case when a tool has its own "getopt.h" with completely different contents not related to getopt(3).) As such, bits from ${WORLDTMP} can only be used as a fallback. I know wonder what happens when you upgrade from RELENG_4 and tools are built in a host environment without /usr/include/gnu. All they use /usr/include/regex.h now where they previously used /usr/include/gnuregex.h. Is this correct? Dangerous? > > David, remove the damn header please. >=20 > Already asked many times... >=20 Perhaps that's the problem? ;) Cheers, --=20 Ruslan Ermilov FreeBSD committer ru@FreeBSD.org --azLHFNyN32YCQGCU Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFASKECUkv4P6juNwoRAjUnAJ4ikuF4w0uCuvUa5r2acYYWhUxCWwCeOYJg Jni0o9vrPEsliL4x2dP7DaQ= =yA8p -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU--