From owner-svn-src-head@freebsd.org Sun Jan 5 04:55:16 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E43991DD6CE; Sun, 5 Jan 2020 04:55:16 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47r5tC4pWNz3Nsw; Sun, 5 Jan 2020 04:55:15 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 052E721B24; Sat, 4 Jan 2020 23:55:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 04 Jan 2020 23:55:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsco.org; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm2; bh=a PYNbb3HTJg2/529k2PxN/CivG8Q+RhhURXZOSo+O2g=; b=E6N/zTuaHTsjtxlo1 yCly5SAYEN0Mx6HAqgrl+qjK7R9XAZ1bEKH/hBKG7Bf90Vp324BkSFuQBAMrWSbG 5Ye9es8B2OkLLyhxaHnl4lTecRjv3/2s4dqJP1nSC78ZBla/n3eWfHXR5P7gOsIX Az6I5J7F/Xz/35mDQsU7qck/D9QAlLNcj16kDQhZEqlsP0ZHh7yuzr5ikrSoShZU +2Ssb30ySGzCkJGdwRgVlJHxwRkSMv4XghLbLeOTlRm9vaho/xvjPYeTqeQQuE3G eWq+g65bObSBgfp2e8/BKGkXkqWv5NK45EsFcA/KhTOVso6WTVdxclLaciIAWHM6 Z9UZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=aPYNbb3HTJg2/529k2PxN/CivG8Q+RhhURXZOSo+O 2g=; b=lWK98CRQaPEQbi52H7PZ3M0JSDQQK4UGbk+KHx/zhugEeAJuFRAl6jpOB 1pOCGlIF0HfmB5gmXhMNRYp5PLlOEKcSilG4ijRFMoTK81CTXZKMRlxW0RQD4b0I eKlcwRJEMIYFmqgaWK2AEw0mykK1zSZiZlOqIVbeV8PUPni1FA7z4dTnSMQAWtLC PgG/ZRN5b+o46bmiVrPgaRYWywQEEDjP82oZE2VDuc/CVIIYDDXPPmi0AjziC2Mr ZpM4QZYkPZrPPZJ0yz8i23K1xqqIm/Vej3IoCuRXBLughTzPjzdodEgkNljn2yNa mlIlnqmY+U76/apccmaHgQLTKlYzw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdegiedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpegtggfuhfgjfffgkfhfvffosehtje hmtdhhtddvnecuhfhrohhmpefutghothhtucfnohhnghcuoehstghothhtlhesshgrmhhs tghordhorhhgqeenucffohhmrghinhepfhhrvggvsghsugdrohhrghenucfkphepudejge drvddvjedruddtrdduheenucfrrghrrghmpehmrghilhhfrhhomhepshgtohhtthhlsehs rghmshgtohdrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from [172.20.10.2] (15.sub-174-227-10.myvzw.com [174.227.10.15]) by mail.messagingengine.com (Postfix) with ESMTPA id 3CA4280060; Sat, 4 Jan 2020 23:55:14 -0500 (EST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\)) Subject: Re: svn commit: r356192 - head/sys/geom From: Scott Long In-Reply-To: <201912300046.xBU0kAhm035303@repo.freebsd.org> Date: Sat, 4 Jan 2020 23:55:13 -0500 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: References: <201912300046.xBU0kAhm035303@repo.freebsd.org> To: Alexander Motin X-Mailer: Apple Mail (2.3601.0.10) X-Rspamd-Queue-Id: 47r5tC4pWNz3Nsw X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=samsco.org header.s=fm2 header.b=E6N/zTua; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=lWK98CRQ; dmarc=none; spf=pass (mx1.freebsd.org: domain of scottl@samsco.org designates 66.111.4.28 as permitted sender) smtp.mailfrom=scottl@samsco.org X-Spamd-Result: default: False [-5.59 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[samsco.org:s=fm2,messagingengine.com:s=fm1]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.28]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MV_CASE(0.50)[]; DMARC_NA(0.00)[samsco.org]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[samsco.org:+,messagingengine.com:+]; RWL_MAILSPIKE_GOOD(0.00)[28.4.111.66.rep.mailspike.net : 127.0.0.18]; IP_SCORE(-3.49)[ip: (-9.84), ipnet: 66.111.4.0/24(-4.88), asn: 11403(-2.68), country: US(-0.05)]; RCVD_IN_DNSWL_LOW(-0.10)[28.4.111.66.list.dnswl.org : 127.0.5.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[15.10.227.174.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Jan 2020 04:55:17 -0000 Good job! > On Dec 29, 2019, at 7:46 PM, Alexander Motin wrote: > > Author: mav > Date: Mon Dec 30 00:46:10 2019 > New Revision: 356192 > URL: https://svnweb.freebsd.org/changeset/base/356192 > > Log: > Retire nstart/nend counters. > > Those counters were abused for decade to workaround broken orphanization > process in different classes by delaying the call while there are active > requests. But from one side it did not close all the races, while from > another was quite expensive on SMP due to trashing twice per request cache > lines of consumer and provider and requiring locks. It lost its sense > after I manually went through all the GEOM classes in base and made > orphanization wait for either provider close or request completion. > > Consumer counters are still used under INVARIANTS to detect premature > consumer close and detach. Provider counters are removed completely. > > Sponsored by: iXsystems, Inc. > > Modified: > head/sys/geom/geom.h > head/sys/geom/geom_event.c > head/sys/geom/geom_io.c > head/sys/geom/geom_subr.c