Date: Wed, 5 Jul 2023 05:46:13 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Mateusz Guzik <mjg@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 55e0aefae688 - main - ping: low-effort fix to make it compilable without inet6 Message-ID: <20230705054613.211731f9@slippy> In-Reply-To: <F6A633FA-85E8-4701-8172-AEB613826690@freebsd.org> References: <202307051003.365A3RqR072876@gitrepo.freebsd.org> <F6A633FA-85E8-4701-8172-AEB613826690@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 5 Jul 2023 11:11:19 +0100 Jessica Clarke <jrtc27@freebsd.org> wrote: > On 5 Jul 2023, at 11:03, Mateusz Guzik <mjg@FreeBSD.org> wrote: > >=20 > > The branch main has been updated by mjg: > >=20 > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D55e0aefae688075718e21259= 4e823fe5fbfba4bf > >=20 > > commit 55e0aefae688075718e212594e823fe5fbfba4bf > > Author: Mateusz Guzik <mjg@FreeBSD.org> > > AuthorDate: 2023-07-05 09:59:40 +0000 > > Commit: Mateusz Guzik <mjg@FreeBSD.org> > > CommitDate: 2023-07-05 10:02:32 +0000 > >=20 > > ping: low-effort fix to make it compilable without inet6 > > --- > > sbin/ping/Makefile | 2 ++ > > 1 file changed, 2 insertions(+) > >=20 > > diff --git a/sbin/ping/Makefile b/sbin/ping/Makefile > > index 23bac6d62d90..ad5dce03363f 100644 > > --- a/sbin/ping/Makefile > > +++ b/sbin/ping/Makefile > > @@ -34,6 +34,8 @@ CFLAGS+=3D-DWITH_CASPER > > CFLAGS+=3D-DIPSEC > > LIBADD+=3D ipsec > >=20 > > +CFLAGS+=3D -Wno-error=3Dunused-but-set-variable > > + =20 >=20 > If we=E2=80=99re going to go with bodges like this should they not at lea= st be > gated on MK_INET6 =3D=3D no or similar? Otherwise the default build where > we are warning-clean today isn=E2=80=99t going to fail when new warnings = are > introduced, which is sub-optimal. Agreed. It's also too easy for someone to subsequently remove the flag when cleaning up. Not everyone reads through commit logs first when commencing work on a component. >=20 > Jess >=20 > > HAS_TESTS=3D > > SUBDIR.${MK_TESTS}+=3D tests > > =20 >=20 --=20 Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org e^(i*pi)+1=3D0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230705054613.211731f9>