From owner-cvs-all Tue Apr 16 17:48:50 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by hub.freebsd.org (Postfix) with ESMTP id 67A0537B42C for ; Tue, 16 Apr 2002 17:48:36 -0700 (PDT) Received: (qmail 2670 invoked from network); 17 Apr 2002 00:48:34 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail14.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 17 Apr 2002 00:48:34 -0000 Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g3H0mSv78449; Tue, 16 Apr 2002 20:48:28 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <65355.1018940734@critter.freebsd.dk> Date: Tue, 16 Apr 2002 20:47:26 -0400 (EDT) From: John Baldwin To: Poul-Henning Kamp Subject: Re: cvs commit: src/sbin/savecore savecore.c Cc: Steve Kargl , cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, "Greg 'groggy' Lehey" , Jeroen Ruigrok/asmodai , obrien@FreeBSD.ORG Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 16-Apr-2002 Poul-Henning Kamp wrote: > In message <20020415235849.A4416@dragon.nuxi.com>, "David O'Brien" writes: >>On Sun, Apr 14, 2002 at 09:03:04AM -0700, Steve Kargl wrote: >>> Marcel's savecore creates 2 files "md5.info" and "md5.core" where >>> "md5" is determined from the md5 checksum of the kernel dump header >>> struct. >> >>Actually that was PHK's. >> >>PHK, what was your motivation in changing the saved core filename? > > I wanted to avoid having to open the disk device in RW mode, so the > best way to find out if we had already saved a dump was to make > a hash of the header and look for that. Hmm, I really don't like that. I find the current scheme of vmcore.XX and kernel.XX to be rather intuitive. For one thing, it makes it very easy to see which dump is the most recent. Why can't you save the hash of the header in the core file or something but still keep the filenames usable. Surely we don't have to give up useful filenames for this. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message